Cleanup code and tests
CI Pipeline / test (20) (pull_request) Successful in 2m55s
CI Pipeline / test (18) (pull_request) Successful in 3m32s
CI Pipeline / e2e (webkit) (pull_request) Has been cancelled
CI Pipeline / visual-regression (pull_request) Has been cancelled
CI Pipeline / performance (pull_request) Has been cancelled
CI Pipeline / storybook (pull_request) Has been cancelled
CI Pipeline / lint (pull_request) Has been cancelled
CI Pipeline / build (pull_request) Has been cancelled
CI Pipeline / e2e (chromium) (pull_request) Has been cancelled
CI Pipeline / e2e (firefox) (pull_request) Has been cancelled

This commit is contained in:
adilallo
2025-10-14 17:34:05 -06:00
parent 9de194bfc0
commit c4a631a5d8
50 changed files with 436 additions and 370 deletions
@@ -71,7 +71,7 @@ describe("Select Component Integration", () => {
await user.click(submitButton);
expect(screen.getByTestId("error")).toHaveTextContent(
"Please select an option"
"Please select an option",
);
});
@@ -298,17 +298,17 @@ describe("Select Component Integration", () => {
name: /Dynamic Select/,
});
expect(selectButton).not.toHaveClass(
"border-[var(--color-border-default-utility-negative)]"
"border-[var(--color-border-default-utility-negative)]",
);
rerender(<DynamicSelect error={true} />);
expect(selectButton).toHaveClass(
"border-[var(--color-border-default-utility-negative)]"
"border-[var(--color-border-default-utility-negative)]",
);
rerender(<DynamicSelect error={false} />);
expect(selectButton).not.toHaveClass(
"border-[var(--color-border-default-utility-negative)]"
"border-[var(--color-border-default-utility-negative)]",
);
});
@@ -339,7 +339,7 @@ describe("Select Component Integration", () => {
expect(selectButton).toHaveFocus();
// Should have focus state styling, not active state
expect(selectButton).toHaveClass(
"focus-visible:border-[var(--color-border-default-utility-info)]"
"focus-visible:border-[var(--color-border-default-utility-info)]",
);
});
@@ -354,7 +354,7 @@ describe("Select Component Integration", () => {
// Click should not trigger focus-visible styles (class is always present but only active on keyboard focus)
// The focus-visible class is always in the component but only applies on keyboard focus
expect(selectButton).toHaveClass(
"focus-visible:border-[var(--color-border-default-utility-info)]"
"focus-visible:border-[var(--color-border-default-utility-info)]",
);
});
});
@@ -392,7 +392,7 @@ describe("Select Component Integration", () => {
label="Large Select"
placeholder="Select an option"
options={largeOptions}
/>
/>,
);
const selectButton = screen.getByRole("button", { name: /Large Select/ });