Keep the template picker in the create flow, make catalog cards real links, and stop showing a fake community when review has no draft. #79

Merged
an.di merged 1 commits from adilallo/fix/CR-183-builder-routing into main 2026-09-10 21:30:10 +00:00
Owner

Overview

Opening the builder mid-flow with no named community still congratulated you on a sample group. Template cards only worked with a mouse, and Create from template sent people to the public catalog and dropped Back / Save & Exit.

This keeps review honest when there is no draft, makes catalog cards real links, and keeps the picker inside the create-flow shell.

Changes

  • /create/review with no community name shows an empty state and Start creating, instead of a baked-in sample community. A named draft still gets the congrats card.
  • Template cards on /templates, the home stack, and the in-flow picker are real anchors (keyboard, new tab). Click still runs the existing draft-reset / analytics side effects.
  • Review Create from template goes to /create/templates (create chrome, Back to review, Save & Exit). Cards open /create/review-template/{slug}?fromFlow=1. Public /templates is unchanged; profile still uses /templates?fromFlow=1.

Screenshots

How to Test

  1. npm run devhttp://localhost:3000.
  2. Empty review: clear create-flow local storage (or a private window), open /create/review. You should see “No community in progress yet”, no sample community name, and Start creating should go to /create/informational.
  3. Named review: name a community, open /create/review. Congrats copy and the rule card should use that name.
  4. In-flow picker: from review, Create from template. You should stay on /create/templates with create chrome (logo, Save & Exit, Back). Back should return to /create/review. Cards should be links to /create/review-template/{slug}?fromFlow=1 (Tab to a card, Enter, or open in a new tab).
  5. Public catalog: /templates should still use marketing chrome. Cards should be links to /create/review-template/{slug} (no fromFlow).
  6. Optional: npx tsc --noEmit and npx vitest run.

Notes

  • Empty review is an empty state, not an auto-redirect, so a signed-in server draft can still hydrate without racing the user off the step.
  • /create/templates is an extra route in the create shell, not a wizard step. Static templates wins over [screenId].
  • Knip still reports unused seedDataRoot; that is unrelated.
## Overview Opening the builder mid-flow with no named community still congratulated you on a sample group. Template cards only worked with a mouse, and **Create from template** sent people to the public catalog and dropped Back / Save & Exit. This keeps review honest when there is no draft, makes catalog cards real links, and keeps the picker inside the create-flow shell. ## Changes - `/create/review` with no community name shows an empty state and **Start creating**, instead of a baked-in sample community. A named draft still gets the congrats card. - Template cards on `/templates`, the home stack, and the in-flow picker are real anchors (keyboard, new tab). Click still runs the existing draft-reset / analytics side effects. - Review **Create from template** goes to `/create/templates` (create chrome, Back to review, Save & Exit). Cards open `/create/review-template/{slug}?fromFlow=1`. Public `/templates` is unchanged; profile still uses `/templates?fromFlow=1`. ## Screenshots ## How to Test 1. `npm run dev` → [http://localhost:3000](http://localhost:3000). 2. **Empty review:** clear create-flow local storage (or a private window), open `/create/review`. You should see “No community in progress yet”, no sample community name, and **Start creating** should go to `/create/informational`. 3. **Named review:** name a community, open `/create/review`. Congrats copy and the rule card should use that name. 4. **In-flow picker:** from review, **Create from template**. You should stay on `/create/templates` with create chrome (logo, Save & Exit, Back). Back should return to `/create/review`. Cards should be links to `/create/review-template/{slug}?fromFlow=1` (Tab to a card, Enter, or open in a new tab). 5. **Public catalog:** `/templates` should still use marketing chrome. Cards should be links to `/create/review-template/{slug}` (no `fromFlow`). 6. Optional: `npx tsc --noEmit` and `npx vitest run`. ## Notes - Empty review is an empty state, not an auto-redirect, so a signed-in server draft can still hydrate without racing the user off the step. - `/create/templates` is an extra route in the create shell, not a wizard step. Static `templates` wins over `[screenId]`. - Knip still reports unused `seedDataRoot`; that is unrelated.
an.di added 1 commit 2026-09-10 21:29:51 +00:00
an.di self-assigned this 2026-09-10 21:29:58 +00:00
an.di merged commit 6ccc1e8c8e into main 2026-09-10 21:30:10 +00:00
an.di deleted branch adilallo/fix/CR-183-builder-routing 2026-09-10 21:30:11 +00:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: CommunityRule/community-rule#79