Footer fix #62

Merged
an.di merged 1 commits from adilallo/fix/CR-121-footer into main 2026-08-15 20:45:10 +00:00
Owner

Title: Footer: right-align nav, fix copyright, adopt CC BY-SA 4.0 (CR-121)

Compare: https://git.medlab.host/CommunityRule/community-rule/compare/main...adilallo/fix/CR-121-footer


Overview

Closes CR-121.

Nathan’s August review flagged three footer issues: nav labels that read as centered, a typo in the rights notice (All right reserved), and interest in a Creative Commons grant matching the live site. This PR right-aligns Use cases / Learn / About at md and up, and replaces the broken rights line with the project’s documented CC BY-SA 4.0 content license.

Changes

  • Nav column alignment (app/components/navigation/Footer.tsx) — pin the footer nav to the right (md:ml-auto) and right-align the labels (md:items-end, md:text-right, md:justify-end). Mobile stays start-aligned. Matches Figma Navigation / Footer (18411:62917).
  • Copyright string (messages/en/components/footer.json) — drop © All right reserved (typo, unnamed entity, and in conflict with a CC grant).
  • Creative Commons — text-only replacement in the same Figma slot: Content licensed under CC BY-SA 4.0, linking to https://creativecommons.org/licenses/by-sa/4.0/ with rel="license". Variant and content scope already documented in README (user-facing content is CC BY-SA 4.0; application source stays GPL-3.0). No badge (would need a CR-116 asset and would diverge from Figma).
  • Tests (tests/components/Footer.test.tsx) — assert right-align classes, license href/rel, and that the old rights notice is gone.

How to Test

  1. npm run dev and open a marketing page (e.g. /about), or npm run storybook → Components / Navigation / Footer.
  2. At < 640px: Use cases / Learn / About stack left-aligned above the org column.
  3. At 640px+: those three links sit on the right edge of the footer with a shared right edge (not centered in the leftover space).
  4. Confirm the bottom-left line reads Content licensed under CC BY-SA 4.0, opens the CC BY-SA 4.0 deed, and that “All right reserved” is gone.
  5. npx vitest run tests/components/Footer.test.tsx

Notes

  • Published user-authored rules are not claimed by this footer line. The legacy site made those CC BY-SA as a platform condition; that grant is a separate product/legal decision.
  • Header Use cases / Learn / About remain centered (Top nav). Out of scope for CR-121.
  • Figma still has the © All right reserved string; copy here intentionally diverges.
**Title:** Footer: right-align nav, fix copyright, adopt CC BY-SA 4.0 (CR-121) **Compare:** https://git.medlab.host/CommunityRule/community-rule/compare/main...adilallo/fix/CR-121-footer --- ## Overview Closes [CR-121](https://linear.app/community-rule/issue/CR-121/footer-fix-nav-column-alignment-correct-copyright-string-adopt). Nathan’s August review flagged three footer issues: nav labels that read as centered, a typo in the rights notice (`All right reserved`), and interest in a Creative Commons grant matching the live site. This PR right-aligns Use cases / Learn / About at `md` and up, and replaces the broken rights line with the project’s documented CC BY-SA 4.0 content license. ## Changes - **Nav column alignment** (`app/components/navigation/Footer.tsx`) — pin the footer nav to the right (`md:ml-auto`) and right-align the labels (`md:items-end`, `md:text-right`, `md:justify-end`). Mobile stays start-aligned. Matches Figma Navigation / Footer (`18411:62917`). - **Copyright string** (`messages/en/components/footer.json`) — drop `© All right reserved` (typo, unnamed entity, and in conflict with a CC grant). - **Creative Commons** — text-only replacement in the same Figma slot: **Content licensed under CC BY-SA 4.0**, linking to https://creativecommons.org/licenses/by-sa/4.0/ with `rel="license"`. Variant and content scope already documented in README (user-facing content is CC BY-SA 4.0; application source stays GPL-3.0). No badge (would need a CR-116 asset and would diverge from Figma). - **Tests** (`tests/components/Footer.test.tsx`) — assert right-align classes, license href/`rel`, and that the old rights notice is gone. ## How to Test 1. `npm run dev` and open a marketing page (e.g. `/about`), or `npm run storybook` → Components / Navigation / Footer. 2. At **< 640px**: Use cases / Learn / About stack left-aligned above the org column. 3. At **640px+**: those three links sit on the right edge of the footer with a shared right edge (not centered in the leftover space). 4. Confirm the bottom-left line reads **Content licensed under CC BY-SA 4.0**, opens the CC BY-SA 4.0 deed, and that “All right reserved” is gone. 5. `npx vitest run tests/components/Footer.test.tsx` ## Notes - Published user-authored rules are **not** claimed by this footer line. The legacy site made those CC BY-SA as a platform condition; that grant is a separate product/legal decision. - Header Use cases / Learn / About remain centered (Top nav). Out of scope for CR-121. - Figma still has the `© All right reserved` string; copy here intentionally diverges.
an.di added 1 commit 2026-08-15 20:44:52 +00:00
an.di self-assigned this 2026-08-15 20:45:00 +00:00
an.di merged commit 2bc190e0c5 into main 2026-08-15 20:45:10 +00:00
an.di deleted branch adilallo/fix/CR-121-footer 2026-08-15 20:45:11 +00:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: CommunityRule/community-rule#62