ESLint Fixes #27

Merged

an.di merged 4 commits from adilallo/maintenance/ESLintFixes into main 2026-01-28 19:44:05 +00:00

Conversation 0 Commits 4 Files Changed 96

+465 -327

an.di commented 2026-01-28 19:13:55 +00:00

Owner

Copy Link

Copy Source

Fix ESLint in CI (resolve lint errors, standardize logging, re-enable lint job)

Overview

This PR resolves the remaining ESLint errors so the runner can enforce linting again. It also standardizes console usage via a small logger wrapper, and re-enables the lint job in Gitea Actions.

Changes

• ESLint: fixed remaining lint errors across tests/stories/scripts (missing imports, unused vars/params, Storybook args, duplicate imports, etc.)
• Logging:
  • Added lib/logger.ts
  • Replaced console.* usage in runtime code (app/ + lib/) with logger.*
  • Updated eslint.config.mjs to error on console.* in app/ + lib/, while allowing console in tests/, stories/, scripts/
• CI: re-enabled lint job in .gitea/workflows/ci.yaml
• Formatting: ran Prettier so prettier --check passes in CI
• Lint script: updated package.json lint script to allow warnings (warnings still visible in output)

Screenshots

How to Test

1. npm ci
2. npm run lint
3. npm exec prettier -- --check "**/*.{js,jsx,ts,tsx,json,css,md}"
4. npm test -- --run
5. npm run e2e

Notes

• Lint warnings remain (e.g. no-img-element, any), but CI now blocks on ESLint errors again.
• logger.debug is dev-only; info/warn/error always emit.

# Fix ESLint in CI (resolve lint errors, standardize logging, re-enable lint job) ## Overview This PR resolves the remaining ESLint errors so the runner can enforce linting again. It also standardizes console usage via a small logger wrapper, and re-enables the `lint` job in Gitea Actions. ## Changes - ESLint: fixed remaining lint errors across tests/stories/scripts (missing imports, unused vars/params, Storybook `args`, duplicate imports, etc.) - Logging: - Added `lib/logger.ts` - Replaced `console.*` usage in runtime code (`app/` + `lib/`) with `logger.*` - Updated `eslint.config.mjs` to error on `console.*` in `app/` + `lib/`, while allowing console in `tests/`, `stories/`, `scripts/` - CI: re-enabled `lint` job in `.gitea/workflows/ci.yaml` - Formatting: ran Prettier so `prettier --check` passes in CI - Lint script: updated `package.json` `lint` script to allow warnings (warnings still visible in output) ## Screenshots <!-- Add image tags if visual changes exist, otherwise leave this section empty --> ## How to Test 1. `npm ci` 2. `npm run lint` 3. `npm exec prettier -- --check "**/*.{js,jsx,ts,tsx,json,css,md}"` 4. `npm test -- --run` 5. `npm run e2e` ## Notes - Lint warnings remain (e.g. `no-img-element`, `any`), but CI now blocks on ESLint errors again. - `logger.debug` is dev-only; `info/warn/error` always emit.

an.di self-assigned this 2026-01-28 19:13:55 +00:00

an.di added 4 commits 2026-01-28 19:13:56 +00:00

Fix ESLint errors 6b8d646f8a

Address ESlint console statements 29a3bd3824

Add ESLint back into CI pipeline 01468ab5c8

Adjust tests after fixing ESLint 29496dbaac

an.di merged commit e7a31789e3 into main 2026-01-28 19:44:05 +00:00

an.di deleted branch adilallo/maintenance/ESLintFixes 2026-01-28 19:44:06 +00:00

an.di referenced this issue from a commit 2026-01-28 19:44:06 +00:00

Merge pull request 'ESLint Fixes' (#27) from adilallo/maintenance/ESLintFixes into main

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

No items

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

an.di (Andy DiLallo) ntnsndr (Nathan Schneider)

No Assignees an.di

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: CommunityRule/community-rule#27