Fix ESLint in CI (resolve lint errors, standardize logging, re-enable lint job)
Overview
This PR resolves the remaining ESLint errors so the runner can enforce linting again. It also standardizes console usage via a small logger wrapper, and re-enables the lint job in Gitea Actions.
Lint warnings remain (e.g. no-img-element, any), but CI now blocks on ESLint errors again.
logger.debug is dev-only; info/warn/error always emit.
# Fix ESLint in CI (resolve lint errors, standardize logging, re-enable lint job)
## Overview
This PR resolves the remaining ESLint errors so the runner can enforce linting again. It also standardizes console usage via a small logger wrapper, and re-enables the `lint` job in Gitea Actions.
## Changes
- ESLint: fixed remaining lint errors across tests/stories/scripts (missing imports, unused vars/params, Storybook `args`, duplicate imports, etc.)
- Logging:
- Added `lib/logger.ts`
- Replaced `console.*` usage in runtime code (`app/` + `lib/`) with `logger.*`
- Updated `eslint.config.mjs` to error on `console.*` in `app/` + `lib/`, while allowing console in `tests/`, `stories/`, `scripts/`
- CI: re-enabled `lint` job in `.gitea/workflows/ci.yaml`
- Formatting: ran Prettier so `prettier --check` passes in CI
- Lint script: updated `package.json` `lint` script to allow warnings (warnings still visible in output)
## Screenshots
<!-- Add image tags if visual changes exist, otherwise leave this section empty -->
## How to Test
1. `npm ci`
2. `npm run lint`
3. `npm exec prettier -- --check "**/*.{js,jsx,ts,tsx,json,css,md}"`
4. `npm test -- --run`
5. `npm run e2e`
## Notes
- Lint warnings remain (e.g. `no-img-element`, `any`), but CI now blocks on ESLint errors again.
- `logger.debug` is dev-only; `info/warn/error` always emit.
an.di
self-assigned this 2026-01-28 19:13:55 +00:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Fix ESLint in CI (resolve lint errors, standardize logging, re-enable lint job)
Overview
This PR resolves the remaining ESLint errors so the runner can enforce linting again. It also standardizes console usage via a small logger wrapper, and re-enables the
lintjob in Gitea Actions.Changes
args, duplicate imports, etc.)lib/logger.tsconsole.*usage in runtime code (app/+lib/) withlogger.*eslint.config.mjsto error onconsole.*inapp/+lib/, while allowing console intests/,stories/,scripts/lintjob in.gitea/workflows/ci.yamlprettier --checkpasses in CIpackage.jsonlintscript to allow warnings (warnings still visible in output)Screenshots
How to Test
npm cinpm run lintnpm exec prettier -- --check "**/*.{js,jsx,ts,tsx,json,css,md}"npm test -- --runnpm run e2eNotes
no-img-element,any), but CI now blocks on ESLint errors again.logger.debugis dev-only;info/warn/erroralways emit.