QA pass: layout, create-flow, and About books #68

Merged
an.di merged 38 commits from adilallo/fix/CR-129-create-rule-button into main 2026-08-26 15:46:56 +00:00
2 changed files with 11 additions and 1 deletions
Showing only changes of commit fc5e3e8d6c - Show all commits
+9 -1
View File
@@ -47,7 +47,15 @@ When your changes create orphans:
The test: Every changed line should trace directly to the user's request.
## 4. Goal-Driven Execution
## 4. Comments, commits, and PRs
**Let the code talk. Keep tickets out of prose.**
- No comment when the names already say it.
- No Linear IDs (`CR-123`) in comments, commit messages, or PR titles/bodies. Branch names still use `adilallo/<type>/CR-<n>-…` (see `branch-naming.mdc`). Link the issue from Linear, not from the PR copy.
- Don't narrate Figma→code mappings the prop already encodes (`palette="inverse"` needs no "this is Invert" comment).
## 5. Goal-Driven Execution
**Define success criteria. Loop until verified.**
+2
View File
@@ -46,6 +46,8 @@ priors — they reflect deliberate decisions.
6. **No new pathname-sniffing chrome.** Compose chrome via group/nested
layouts, not `usePathname()` checks. (`ConditionalNavigation` is the
sole tolerated exception — it carries SSR session state.)
7. **No Linear ticket IDs in comments, commits, or PR copy.** Branch names
still carry `CR-<n>`. See `coding-guidelines.mdc`.
## Legacy / scaffolding