QA pass: layout, create-flow, and About books #68
@@ -47,7 +47,15 @@ When your changes create orphans:
|
|||||||
|
|
||||||
The test: Every changed line should trace directly to the user's request.
|
The test: Every changed line should trace directly to the user's request.
|
||||||
|
|
||||||
## 4. Goal-Driven Execution
|
## 4. Comments, commits, and PRs
|
||||||
|
|
||||||
|
**Let the code talk. Keep tickets out of prose.**
|
||||||
|
|
||||||
|
- No comment when the names already say it.
|
||||||
|
- No Linear IDs (`CR-123`) in comments, commit messages, or PR titles/bodies. Branch names still use `adilallo/<type>/CR-<n>-…` (see `branch-naming.mdc`). Link the issue from Linear, not from the PR copy.
|
||||||
|
- Don't narrate Figma→code mappings the prop already encodes (`palette="inverse"` needs no "this is Invert" comment).
|
||||||
|
|
||||||
|
## 5. Goal-Driven Execution
|
||||||
|
|
||||||
**Define success criteria. Loop until verified.**
|
**Define success criteria. Loop until verified.**
|
||||||
|
|
||||||
|
|||||||
@@ -46,6 +46,8 @@ priors — they reflect deliberate decisions.
|
|||||||
6. **No new pathname-sniffing chrome.** Compose chrome via group/nested
|
6. **No new pathname-sniffing chrome.** Compose chrome via group/nested
|
||||||
layouts, not `usePathname()` checks. (`ConditionalNavigation` is the
|
layouts, not `usePathname()` checks. (`ConditionalNavigation` is the
|
||||||
sole tolerated exception — it carries SSR session state.)
|
sole tolerated exception — it carries SSR session state.)
|
||||||
|
7. **No Linear ticket IDs in comments, commits, or PR copy.** Branch names
|
||||||
|
still carry `CR-<n>`. See `coding-guidelines.mdc`.
|
||||||
|
|
||||||
## Legacy / scaffolding
|
## Legacy / scaffolding
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user