CommunityRule/community-rule
2
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

QA pass: layout, create-flow, and About books #68

Merged
an.di merged 38 commits from adilallo/fix/CR-129-create-rule-button into main 2026-08-26 15:46:56 +00:00
Conversation 0 Commits 38 Files Changed 202
+10 -5
2 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 7ea0a52bf1 - Show all commits
app/components/navigation/Top/Top.view.tsx
+2 -5
View File
@@ -170,13 +170,10 @@ function TopView({
<nav <nav
className="relative flex w-full items-center className="relative flex w-full items-center
px-[var(--spacing-scale-016)] px-[var(--spacing-scale-016)]
py-[var(--spacing-scale-016)] py-[var(--spacing-scale-008)]
sm:px-[var(--spacing-measures-spacing-016)] sm:px-[var(--spacing-measures-spacing-016)]
sm:py-[var(--spacing-scale-016)]
lg:px-[var(--spacing-measures-spacing-64,64px)] lg:px-[var(--spacing-measures-spacing-64,64px)]
lg:py-[var(--spacing-scale-016)] lg:py-[var(--spacing-scale-016)]"
xl:py-[var(--spacing-scale-016)]
min-h-[var(--spacing-scale-040)]"
role="navigation" role="navigation"
aria-label={t("ariaLabels.mainNavigation")} aria-label={t("ariaLabels.mainNavigation")}
> >
tests/components/Top.test.tsx
+8
View File
@@ -101,6 +101,14 @@ describe('Top "Create rule" button', () => {
).toBeNull(); ).toBeNull();
}); });
it("pads the standard header to hug Create rule", () => {
renderWithProviders(<Top folderTop={false} />);
const nav = screen.getByRole("navigation", { name: "Main navigation" });
expect(nav.className).toContain("py-[var(--spacing-scale-008)]");
expect(nav.className).toContain("lg:py-[var(--spacing-scale-016)]");
expect(nav.className).not.toContain("min-h-[var(--spacing-scale-040)]");
});
it("uses filled invert for Create rule", () => { it("uses filled invert for Create rule", () => {
for (const folderTop of [false, true]) { for (const folderTop of [false, true]) {
const { unmount } = renderWithProviders(<Top folderTop={folderTop} />); const { unmount } = renderWithProviders(<Top folderTop={folderTop} />);