Show the Profile empty state, phone layout, and Rules you belong to #106
No files matched your search
@@ -60,6 +60,7 @@ export default function ProfilePageClient() {
|
||||
const [sessionLoaded, setSessionLoaded] = useState(false);
|
||||
const [user, setUser] = useState<{ id: string; email: string } | null>(null);
|
||||
const [rules, setRules] = useState<MyPublishedRule[]>([]);
|
||||
const [rulesLoaded, setRulesLoaded] = useState(false);
|
||||
const [rulesError, setRulesError] = useState(false);
|
||||
const [draft, setDraft] = useState<
|
||||
Awaited<ReturnType<typeof fetchServerDraftForProfile>>
|
||||
@@ -92,6 +93,7 @@ export default function ProfilePageClient() {
|
||||
setSessionLoaded(true);
|
||||
if (!u) {
|
||||
setRules([]);
|
||||
setRulesLoaded(false);
|
||||
setRulesError(false);
|
||||
setDraft(null);
|
||||
return;
|
||||
@@ -101,10 +103,11 @@ export default function ProfilePageClient() {
|
||||
fetchServerDraftForProfile(),
|
||||
]);
|
||||
if (r === null) {
|
||||
setRules([]);
|
||||
setRulesLoaded(false);
|
||||
setRulesError(true);
|
||||
} else {
|
||||
setRules(r);
|
||||
setRulesLoaded(true);
|
||||
setRulesError(false);
|
||||
}
|
||||
setDraft(d);
|
||||
@@ -435,6 +438,7 @@ export default function ProfilePageClient() {
|
||||
profileLgUp={isProfileLgUp}
|
||||
profileListSize={isProfileXlUp ? "l" : "m"}
|
||||
rules={rules}
|
||||
rulesLoaded={rulesLoaded}
|
||||
rulesError={rulesError}
|
||||
draft={draft}
|
||||
showDraftCard={showDraftCard}
|
||||
|
||||
@@ -46,6 +46,8 @@ export type ProfilePageViewProps = {
|
||||
/** `m` = {@link List} M; `l` = List L at `xl` per Figma `22143:900256`. */
|
||||
profileListSize: Extract<ListSize, "m" | "l">;
|
||||
rules: MyPublishedRule[];
|
||||
/** True only after `fetchMyPublishedRules` succeeds. Dismissing the warning does not set this. */
|
||||
rulesLoaded: boolean;
|
||||
rulesError: boolean;
|
||||
draft: ServerDraftForProfile | null;
|
||||
showDraftCard: boolean;
|
||||
@@ -171,6 +173,7 @@ export function ProfilePageView({
|
||||
profileLgUp,
|
||||
profileListSize,
|
||||
rules,
|
||||
rulesLoaded,
|
||||
rulesError,
|
||||
draft,
|
||||
showDraftCard,
|
||||
@@ -235,7 +238,10 @@ export function ProfilePageView({
|
||||
? t("welcomeBodyFirstRule")
|
||||
: undefined;
|
||||
const showEmptyYourRules =
|
||||
ownedRules.length === 0 && !showDraftCard && !rulesError;
|
||||
rulesLoaded &&
|
||||
ownedRules.length === 0 &&
|
||||
!showDraftCard &&
|
||||
!rulesError;
|
||||
|
||||
const profileOptionsItems = useMemo((): ListItem[] => {
|
||||
return [
|
||||
|
||||
@@ -27,6 +27,7 @@ function viewProps(
|
||||
profileLgUp: true,
|
||||
profileListSize: "l",
|
||||
rules: [],
|
||||
rulesLoaded: true,
|
||||
rulesError: false,
|
||||
draft: null,
|
||||
showDraftCard: false,
|
||||
@@ -128,6 +129,32 @@ describe("ProfilePageView", () => {
|
||||
expect(onStartNewCustomRule).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
test("keeps the No Rules card hidden when a failed load warning is dismissed", () => {
|
||||
const { rerender } = render(
|
||||
<ProfilePageView
|
||||
{...viewProps({ rulesLoaded: false, rulesError: true })}
|
||||
/>,
|
||||
);
|
||||
|
||||
expect(screen.getByText(copy.rulesLoadBannerTitle)).toBeInTheDocument();
|
||||
expect(
|
||||
screen.queryByRole("heading", { name: copy.emptyCardTitle }),
|
||||
).not.toBeInTheDocument();
|
||||
|
||||
rerender(
|
||||
<ProfilePageView
|
||||
{...viewProps({ rulesLoaded: false, rulesError: false })}
|
||||
/>,
|
||||
);
|
||||
|
||||
expect(
|
||||
screen.queryByText(copy.rulesLoadBannerTitle),
|
||||
).not.toBeInTheDocument();
|
||||
expect(
|
||||
screen.queryByRole("heading", { name: copy.emptyCardTitle }),
|
||||
).not.toBeInTheDocument();
|
||||
});
|
||||
|
||||
test("asks for confirmation before deleting the account", async () => {
|
||||
const user = userEvent.setup();
|
||||
const onOpenDeleteAccount = vi.fn();
|
||||
|
||||
Reference in new issue
Block a user