Give MultiSelect chips accessible names and start creation fields empty. #85

Merged
an.di merged 1 commits from adilallo/fix/CR-220-CR-209-chip-names-creation-modal into main 2026-10-01 15:52:24 +00:00
Member

Overview

Catalog chips on the structure, size, and values steps were unnamed for assistive tech. Method and value creation fields also opened already filled with catalog copy.

This names each non-custom MultiSelect chip Select or Deselect, and opens those creation fields empty. Generate draft inserts the catalog copy that used to be prefilled.

Changes

  • MultiSelect sets Select {label} / Deselect {label} on catalog chips (structure, size, values, and the same chip control on final review). Chip only exposes aria-label when one is provided.
  • Creation modals for values and methods start with empty text fields. Generate draft (plus the short hint) fills in the catalog preset for that section. Saved overrides still reopen with the saved text.
  • TextArea gains a compose appearance for the tall empty field. Customize still shows the catalog section headings when the copy is empty, so the wizard is not missing blocks.
  • Copy lives in controlsChrome (chipSelect / chipDeselect) and create.draftField.

How to Test

  1. Run the app locally and go through create from /create.
  2. On /create/community-structure, /create/community-size, and /create/core-values, inspect a chip: selected chips keep the checkmark; the button name should be Select … or Deselect …. Repeat on /create/final-review chips.
  3. Click a catalog value (e.g. Accessibility) or a method card (e.g. Signal on /create/communication-methods). The text fields should start empty. Generate draft should insert the catalog copy. Saving, then reopening, should show what you saved.
  4. Add value still opens the custom-policy wizard, not this modal.
  5. Optional: Storybook → ModalTextAreaField → GenerateDraft.

Notes

  • Batch 6 layout rewrite should keep these names on MultiSelect rather than restating them in screen markup.
  • Publish still merges empty field overrides onto catalog presets so unpublished sections are not dropped.
## Overview Catalog chips on the structure, size, and values steps were unnamed for assistive tech. Method and value creation fields also opened already filled with catalog copy. This names each non-custom MultiSelect chip Select or Deselect, and opens those creation fields empty. Generate draft inserts the catalog copy that used to be prefilled. ## Changes - MultiSelect sets `Select {label}` / `Deselect {label}` on catalog chips (structure, size, values, and the same chip control on final review). Chip only exposes `aria-label` when one is provided. - Creation modals for values and methods start with empty text fields. Generate draft (plus the short hint) fills in the catalog preset for that section. Saved overrides still reopen with the saved text. - TextArea gains a `compose` appearance for the tall empty field. Customize still shows the catalog section headings when the copy is empty, so the wizard is not missing blocks. - Copy lives in `controlsChrome` (`chipSelect` / `chipDeselect`) and `create.draftField`. ## How to Test 1. Run the app locally and go through create from `/create`. 2. On `/create/community-structure`, `/create/community-size`, and `/create/core-values`, inspect a chip: selected chips keep the checkmark; the button name should be `Select …` or `Deselect …`. Repeat on `/create/final-review` chips. 3. Click a catalog value (e.g. Accessibility) or a method card (e.g. Signal on `/create/communication-methods`). The text fields should start empty. Generate draft should insert the catalog copy. Saving, then reopening, should show what you saved. 4. Add value still opens the custom-policy wizard, not this modal. 5. Optional: Storybook → ModalTextAreaField → GenerateDraft. ## Notes - Batch 6 layout rewrite should keep these names on MultiSelect rather than restating them in screen markup. - Publish still merges empty field overrides onto catalog presets so unpublished sections are not dropped.
an.di added 1 commit 2026-10-01 15:52:04 +00:00
Catalog chips now announce Select or Deselect so they are named for assistive tech. Method and value modals open blank; Generate draft inserts the catalog copy that used to be prefilled, and Customize still keeps the section headings.

Co-authored-by: Cursor <cursoragent@cursor.com>
an.di self-assigned this 2026-10-01 15:52:10 +00:00
an.di merged commit 2fc7fbf818 into main 2026-10-01 15:52:24 +00:00
an.di deleted branch adilallo/fix/CR-220-CR-209-chip-names-creation-modal 2026-10-01 15:52:24 +00:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: CommunityRule/community-rule#85