Show the save-email error, and open review cards as the deck row view #105

Merged
an.di merged 2 commits from adilallo/fix/CR-279-save-email-review-card into main 2026-11-11 18:20:49 +00:00
Member

Overview

A bad address on Save your progress never reached our own error line, because the browser’s bubble blocked the submit. On final review, opening a method card showed every part stacked in one editor instead of the three-row card the decks already use.

Changes

  • The save-progress form skips the browser’s email check, so Submit email shows “Check your email address. We need it to send your link.” for not-an-email and for an address with no dot in the domain, such as maya@example.
  • A method chip on final review opens the same routing card as the decks: one row per part (Core principle and scope, How it works, Norms), then that part’s own editor with Generate draft.
  • Save on a part returns to the rows. Save on the card keeps the edit, and stays off until a part has changed. The footer action on a picked card is Deselect.
  • The old stacked editors for those four decks are removed. Custom cards that already have their own fields still open that body.

Screenshots

How to Test

  1. Run the app and open /create/community-save.
  2. Type not-an-email and choose Submit email. The field should show “Check your email address. We need it to send your link.” The browser bubble should not appear.
  3. Clear it, type maya@example, and submit again. The same line should show.
  4. Open /create/final-review with a Signal card on the Rule. Select the Signal chip.
  5. Confirm the dialog shows three rows, plus Deselect, Cancel, and a disabled Save. It should not show all three fields at once.
  6. Open Core principle and scope. The field should be empty, with Generate draft. Save returns to the three rows and enables Save. Save again keeps the sentence on the card.
  7. Close without that second Save. The typed sentence should be discarded.

Notes

  • The “check your email” toast still appears only after a link is actually sent. This change does not send one.
## Overview A bad address on Save your progress never reached our own error line, because the browser’s bubble blocked the submit. On final review, opening a method card showed every part stacked in one editor instead of the three-row card the decks already use. ## Changes - The save-progress form skips the browser’s email check, so Submit email shows “Check your email address. We need it to send your link.” for `not-an-email` and for an address with no dot in the domain, such as `maya@example`. - A method chip on final review opens the same routing card as the decks: one row per part (Core principle and scope, How it works, Norms), then that part’s own editor with Generate draft. - Save on a part returns to the rows. Save on the card keeps the edit, and stays off until a part has changed. The footer action on a picked card is Deselect. - The old stacked editors for those four decks are removed. Custom cards that already have their own fields still open that body. ## Screenshots ## How to Test 1. Run the app and open `/create/community-save`. 2. Type `not-an-email` and choose Submit email. The field should show “Check your email address. We need it to send your link.” The browser bubble should not appear. 3. Clear it, type `maya@example`, and submit again. The same line should show. 4. Open `/create/final-review` with a Signal card on the Rule. Select the Signal chip. 5. Confirm the dialog shows three rows, plus Deselect, Cancel, and a disabled Save. It should not show all three fields at once. 6. Open Core principle and scope. The field should be empty, with Generate draft. Save returns to the three rows and enables Save. Save again keeps the sentence on the card. 7. Close without that second Save. The typed sentence should be discarded. ## Notes - The “check your email” toast still appears only after a link is actually sent. This change does not send one.
an.di added 2 commits 2026-11-11 18:20:33 +00:00
A bad address was stopped by the browser bubble before the designed line could appear. Final review opened every part of a method card at once instead of the three-row policy the decks use.
an.di self-assigned this 2026-11-11 18:20:40 +00:00
an.di merged commit e08884efde into main 2026-11-11 18:20:49 +00:00
an.di deleted branch adilallo/fix/CR-279-save-email-review-card 2026-11-11 18:20:49 +00:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: CommunityRule/community-rule#105