Send FeatureGrid Learn more to the Learn page instead of a dead hash link.
This commit is contained in:
@@ -94,9 +94,9 @@ function ContentLockupView({
|
||||
)}
|
||||
|
||||
{/* Link for feature variant */}
|
||||
{variant === "feature" && linkText && (
|
||||
{variant === "feature" && linkText && linkHref && (
|
||||
<a
|
||||
href={linkHref || "#"}
|
||||
href={linkHref}
|
||||
className="text-medium-underline underline text-[var(--color-content-default-primary)] hover:text-[var(--color-content-default-secondary)] transition-colors focus:outline-none focus:ring-2 focus:ring-[var(--color-surface-default-brand-royal)] focus:ring-offset-2 focus:ring-offset-[var(--color-surface-default-secondary)] rounded-sm px-1 py-0.5"
|
||||
>
|
||||
{linkText}
|
||||
|
||||
@@ -1,7 +1,7 @@
|
||||
{
|
||||
"_comment": "FeatureGrid component defaults (shared across pages). linkHref is a stub until destination pages ship.",
|
||||
"_comment": "FeatureGrid component defaults (shared across pages). Learn more goes to /learn; feature cards stay non-interactive until destinations are decided.",
|
||||
"linkText": "Learn more",
|
||||
"linkHref": "#",
|
||||
"linkHref": "/learn",
|
||||
"ariaLabel": "Feature tools and services",
|
||||
"features": {
|
||||
"decisionMaking": {
|
||||
|
||||
@@ -53,7 +53,7 @@ export const FeatureWithLink = {
|
||||
"Use our toolkit to improve, document, and evolve your organization.",
|
||||
variant: "feature",
|
||||
linkText: "Learn more",
|
||||
linkHref: "#",
|
||||
linkHref: "/learn",
|
||||
},
|
||||
};
|
||||
|
||||
|
||||
@@ -57,6 +57,14 @@ describe("FeatureGrid (behavioral tests)", () => {
|
||||
).not.toBeInTheDocument();
|
||||
});
|
||||
|
||||
it("sends Learn more to the Learn page", () => {
|
||||
render(<FeatureGrid title="Test" subtitle="Test" />);
|
||||
expect(screen.getByRole("link", { name: "Learn more" })).toHaveAttribute(
|
||||
"href",
|
||||
"/learn",
|
||||
);
|
||||
});
|
||||
|
||||
it("does not apply a focus ring to the entire grid shell", () => {
|
||||
render(<FeatureGrid title="Test" subtitle="Test" />);
|
||||
const shell = document.querySelector('[data-figma-node="18847-22410"]');
|
||||
|
||||
@@ -131,7 +131,10 @@ test.describe("Critical User Journeys", () => {
|
||||
await expect(
|
||||
featureSection.locator('a[href="#decision-making"]'),
|
||||
).toHaveCount(0);
|
||||
await expect(featureSection.getByRole("link", { name: "Learn more" })).toBeVisible();
|
||||
await expect(featureSection.getByRole("link", { name: "Learn more" })).toHaveAttribute(
|
||||
"href",
|
||||
"/learn",
|
||||
);
|
||||
});
|
||||
|
||||
test("header navigation functionality", async ({ page }) => {
|
||||
|
||||
@@ -120,6 +120,8 @@ describe("Page", () => {
|
||||
"Use our toolkit to improve, document, and evolve your organization.",
|
||||
).length,
|
||||
).toBeGreaterThan(0);
|
||||
const learnMore = screen.getAllByRole("link", { name: "Learn more" });
|
||||
expect(learnMore[0]).toHaveAttribute("href", "/learn");
|
||||
});
|
||||
|
||||
test("renders ask organizer section with correct data", () => {
|
||||
|
||||
Reference in New Issue
Block a user