Show the Profile empty state, phone layout, and Rules you belong to.

This commit is contained in:
adilallo committed 2026-11-11 11:33:21 -07:00
1 parent b1ae274ff6
commit c332b26683
4 files changed
+383 -138

No files matched your search

+130 -9
View File
@@ -72,7 +72,7 @@ function viewProps(
}
describe("ProfilePageView", () => {
test("puts delete account in its own danger area", () => {
test("puts delete account in the options list as a danger row", () => {
render(<ProfilePageView {...viewProps()} />);
const options = screen.getByRole("navigation", {
@@ -81,16 +81,12 @@ describe("ProfilePageView", () => {
expect(
within(options).getByRole("button", { name: copy.optionCreateCustom }),
).toBeInTheDocument();
expect(
within(options).queryByRole("button", { name: copy.deleteAccount }),
).not.toBeInTheDocument();
expect(screen.queryByText(copy.deleteAccountIntro)).not.toBeInTheDocument();
expect(
screen.queryByRole("region", { name: copy.deleteAccount }),
).not.toBeInTheDocument();
const danger = screen.getByRole("region", { name: copy.deleteAccount });
expect(danger.className).toContain(
"border-[var(--color-border-default-negative-primary)]",
);
const deleteAccount = within(danger).getByRole("button", {
const deleteAccount = within(options).getByRole("button", {
name: copy.deleteAccount,
});
const deleteTitle = within(deleteAccount).getByText(copy.deleteAccount);
@@ -105,6 +101,33 @@ describe("ProfilePageView", () => {
);
});
test("shows the No Rules card when the person has no owned Rule", async () => {
const user = userEvent.setup();
const onStartNewCustomRule = vi.fn();
render(
<ProfilePageView {...viewProps({ onStartNewCustomRule })} />,
);
expect(
screen.getByRole("heading", {
name: copy.welcomeTitleReturn.replace("{{name}}", "dani@example.com"),
}),
).toBeInTheDocument();
expect(screen.queryByText(copy.welcomeBodyFirstRule)).not.toBeInTheDocument();
expect(
screen.getByRole("heading", { name: copy.emptyCardTitle }),
).toBeInTheDocument();
expect(screen.getByText(copy.emptyCardBody)).toBeInTheDocument();
expect(
screen.getByRole("link", { name: copy.emptyCardBrowse }),
).toHaveAttribute("href", "/templates?fromFlow=1");
await user.click(
screen.getByRole("button", { name: copy.emptyCardCreate }),
);
expect(onStartNewCustomRule).toHaveBeenCalledTimes(1);
});
test("asks for confirmation before deleting the account", async () => {
const user = userEvent.setup();
const onOpenDeleteAccount = vi.fn();
@@ -193,4 +216,102 @@ describe("ProfilePageView", () => {
screen.getByRole("button", { name: copy.deleteRule }),
).toBeInTheDocument();
});
test("lists invited Rules under Rules you belong to, not Your Rules", () => {
render(
<ProfilePageView
{...viewProps({
rules: [
{
id: "rule-owned",
title: "Garden coop",
summary: "How we share the plots.",
createdAt: "2026-11-01T00:00:00.000Z",
updatedAt: "2026-11-01T00:00:00.000Z",
role: "owner",
},
{
id: "rule-invited",
title: "Hawthorn Row Seed Library",
summary: "Neighbors save seeds each fall.",
createdAt: "2026-10-01T00:00:00.000Z",
updatedAt: "2026-10-01T00:00:00.000Z",
role: "stakeholder",
},
],
})}
/>,
);
expect(
screen.getByRole("heading", { name: copy.rulesYouBelongToHeading }),
).toBeInTheDocument();
expect(
screen.getByRole("link", { name: /Hawthorn Row Seed Library/ }),
).toHaveAttribute("href", "/invite/rule-invited");
expect(
screen.queryByRole("button", { name: copy.viewPublic }),
).not.toBeInTheDocument();
const yourRules = screen.getByRole("region", {
name: copy.yourRulesHeading,
});
expect(within(yourRules).getByText("Garden coop")).toBeInTheDocument();
expect(
within(yourRules).queryByText("Hawthorn Row Seed Library"),
).not.toBeInTheDocument();
expect(
within(yourRules).getByRole("button", { name: copy.inviteMembers }),
).toBeInTheDocument();
});
test("hides Rules you belong to when nothing was shared with this address", () => {
render(
<ProfilePageView
{...viewProps({
rules: [
{
id: "rule-1",
title: "Garden coop",
summary: "How we share the plots.",
createdAt: "2026-11-01T00:00:00.000Z",
updatedAt: "2026-11-01T00:00:00.000Z",
role: "owner",
},
],
})}
/>,
);
expect(
screen.queryByRole("heading", { name: copy.rulesYouBelongToHeading }),
).not.toBeInTheDocument();
});
test("uses the return-visit greeting when a draft is in progress", () => {
render(
<ProfilePageView
{...viewProps({
showDraftCard: true,
draft: {
hasDraft: true,
updatedAt: "2026-11-01T00:00:00.000Z",
state: { title: "Alder Court Tenants Union" },
} as ProfilePageViewProps["draft"],
})}
/>,
);
expect(
screen.getByRole("heading", {
name: copy.welcomeTitleReturn.replace("{{name}}", "dani@example.com"),
}),
).toBeInTheDocument();
expect(screen.getByText(copy.welcomeBodyReturn)).toBeInTheDocument();
expect(screen.getByText("Alder Court Tenants Union")).toBeInTheDocument();
expect(screen.getByText(copy.draftInProgressBadge)).toBeInTheDocument();
expect(
screen.getByRole("button", { name: copy.continueDraft }),
).toBeInTheDocument();
});
});