Rebuild Share and Delete Account from the privacy designs.
Share asks the person who holds the pen to confirm their community agreed before a link turns on, and deleting an account lists each owned Rule with PDF and RULE.md export. Case-study Share copies the page link instead of opening the privacy modal, and the sign-in banner stays below the header so Share remains clickable.
This commit is contained in:
1 parent
5cbda35e32
commit
b6795c1f18
28 files changed
+1467
-377
No files matched your search
@@ -1,117 +1,149 @@
|
||||
import { describe, it, expect, vi } from "vitest";
|
||||
import { describe, it, expect, vi, beforeEach } from "vitest";
|
||||
import userEvent from "@testing-library/user-event";
|
||||
import { renderWithProviders as render, screen } from "../../utils/test-utils";
|
||||
import { fireEvent } from "@testing-library/react";
|
||||
import {
|
||||
renderWithProviders as render,
|
||||
screen,
|
||||
waitFor,
|
||||
} from "../../utils/test-utils";
|
||||
import "@testing-library/jest-dom/vitest";
|
||||
import Share from "../../../app/components/modals/Share";
|
||||
import type { RuleShareSettings } from "../../../lib/ruleShareTypes";
|
||||
|
||||
const noopHandlers = {
|
||||
onCopyLink: vi.fn(),
|
||||
onEmailShare: vi.fn(),
|
||||
onSignalShare: vi.fn(),
|
||||
onSlackShare: vi.fn(),
|
||||
onDiscordShare: vi.fn(),
|
||||
const previewSettings: RuleShareSettings = {
|
||||
visibility: "private",
|
||||
shareSlug: null,
|
||||
shareUrl: "https://communityrule.info/rules/rule-1",
|
||||
shareUrlDisplay: null,
|
||||
title: "Juniper Street Food Share",
|
||||
ownerEmail: "name@example.org",
|
||||
ownerInitials: "N",
|
||||
readers: [
|
||||
{ email: "rosa@example.org", initials: "R", role: "reader" },
|
||||
{ email: "a@example.org", initials: "A", role: "reader" },
|
||||
{ email: "b@example.org", initials: "B", role: "reader" },
|
||||
{ email: "c@example.org", initials: "C", role: "reader" },
|
||||
{ email: "d@example.org", initials: "D", role: "reader" },
|
||||
{ email: "e@example.org", initials: "E", role: "reader" },
|
||||
],
|
||||
copyEnabled: true,
|
||||
};
|
||||
|
||||
function openShare(overrides: Partial<RuleShareSettings> = {}) {
|
||||
return render(
|
||||
<Share
|
||||
isOpen
|
||||
onClose={vi.fn()}
|
||||
previewSettings={{ ...previewSettings, ...overrides }}
|
||||
/>,
|
||||
);
|
||||
}
|
||||
|
||||
const writeText = vi.fn().mockResolvedValue(undefined);
|
||||
|
||||
beforeEach(() => {
|
||||
writeText.mockReset();
|
||||
writeText.mockResolvedValue(undefined);
|
||||
Object.defineProperty(window.navigator, "clipboard", {
|
||||
configurable: true,
|
||||
value: { writeText },
|
||||
});
|
||||
});
|
||||
|
||||
describe("Share modal", () => {
|
||||
it("does not render dialog when closed", () => {
|
||||
render(
|
||||
<Share isOpen={false} onClose={vi.fn()} {...noopHandlers} />,
|
||||
<Share
|
||||
isOpen={false}
|
||||
onClose={vi.fn()}
|
||||
previewSettings={previewSettings}
|
||||
/>,
|
||||
);
|
||||
expect(screen.queryByRole("dialog")).not.toBeInTheDocument();
|
||||
});
|
||||
|
||||
it("renders localized heading and copy link action when open", async () => {
|
||||
const user = userEvent.setup();
|
||||
const onCopyLink = vi.fn();
|
||||
render(
|
||||
<Share
|
||||
isOpen={true}
|
||||
onClose={vi.fn()}
|
||||
{...noopHandlers}
|
||||
onCopyLink={onCopyLink}
|
||||
/>,
|
||||
);
|
||||
it("renders invite-only copy and people with access", () => {
|
||||
openShare();
|
||||
expect(screen.getByRole("dialog")).toBeInTheDocument();
|
||||
expect(
|
||||
screen.getByRole("heading", { level: 1, name: /Share this CommunityRule/ }),
|
||||
screen.getByRole("heading", { level: 1, name: "Share this Rule" }),
|
||||
).toBeInTheDocument();
|
||||
await user.click(screen.getByRole("button", { name: "Copy link" }));
|
||||
expect(onCopyLink).toHaveBeenCalledTimes(1);
|
||||
expect(screen.getByText("Juniper Street Food Share")).toBeInTheDocument();
|
||||
expect(screen.getByText("You")).toBeInTheDocument();
|
||||
expect(screen.getByText("rosa@example.org")).toBeInTheDocument();
|
||||
expect(screen.getByText("Five more people can read it")).toBeInTheDocument();
|
||||
expect(screen.getByText("Only people you invite can open it.")).toBeInTheDocument();
|
||||
});
|
||||
|
||||
it("invokes channel handlers for Signal, Slack, and Discord", async () => {
|
||||
const user = userEvent.setup();
|
||||
const onSignalShare = vi.fn();
|
||||
const onSlackShare = vi.fn();
|
||||
const onDiscordShare = vi.fn();
|
||||
render(
|
||||
<Share
|
||||
isOpen={true}
|
||||
onClose={vi.fn()}
|
||||
{...noopHandlers}
|
||||
onSignalShare={onSignalShare}
|
||||
onSlackShare={onSlackShare}
|
||||
onDiscordShare={onDiscordShare}
|
||||
/>,
|
||||
it("copies the private Rule URL", async () => {
|
||||
openShare();
|
||||
fireEvent.click(screen.getByRole("button", { name: /Copy link/i }));
|
||||
await waitFor(() => {
|
||||
expect(screen.getByText("Link copied")).toBeInTheDocument();
|
||||
});
|
||||
expect(writeText).toHaveBeenCalledWith(
|
||||
"https://communityrule.info/rules/rule-1",
|
||||
);
|
||||
await user.click(screen.getByRole("button", { name: "Signal" }));
|
||||
await user.click(screen.getByRole("button", { name: "Slack" }));
|
||||
await user.click(screen.getByRole("button", { name: "Discord" }));
|
||||
expect(onSignalShare).toHaveBeenCalledTimes(1);
|
||||
expect(onSlackShare).toHaveBeenCalledTimes(1);
|
||||
expect(onDiscordShare).toHaveBeenCalledTimes(1);
|
||||
expect(screen.getByRole("button", { name: /Copied/i })).toHaveAttribute(
|
||||
"aria-pressed",
|
||||
"true",
|
||||
);
|
||||
});
|
||||
|
||||
it("asks for community agreement before turning a link on", async () => {
|
||||
const user = userEvent.setup();
|
||||
openShare();
|
||||
await user.click(screen.getByRole("button", { name: /Only people you invite/i }));
|
||||
await user.click(
|
||||
await screen.findByRole("option", { name: "Anyone with the link" }),
|
||||
);
|
||||
expect(
|
||||
screen.getByText(
|
||||
"Anyone with the link can read it without logging in and pass it on. Check with your community first.",
|
||||
),
|
||||
).toBeInTheDocument();
|
||||
expect(screen.getByRole("button", { name: "Turn on link" })).toBeDisabled();
|
||||
expect(screen.getByRole("button", { name: /Copy link/i })).toBeDisabled();
|
||||
await user.click(
|
||||
screen.getByRole("checkbox", {
|
||||
name: "Our community agreed to share this Rule",
|
||||
}),
|
||||
);
|
||||
expect(screen.getByRole("button", { name: "Turn on link" })).toBeEnabled();
|
||||
});
|
||||
|
||||
it("turns the preview link on after community agreement", async () => {
|
||||
const user = userEvent.setup();
|
||||
openShare();
|
||||
await user.click(screen.getByRole("button", { name: /Only people you invite/i }));
|
||||
await user.click(
|
||||
await screen.findByRole("option", { name: "Anyone with the link" }),
|
||||
);
|
||||
await user.click(
|
||||
screen.getByRole("checkbox", {
|
||||
name: "Our community agreed to share this Rule",
|
||||
}),
|
||||
);
|
||||
await user.click(screen.getByRole("button", { name: "Turn on link" }));
|
||||
expect(
|
||||
screen.getByDisplayValue("communityrule.info/r/k7f2-9qxm"),
|
||||
).toBeInTheDocument();
|
||||
expect(
|
||||
screen.getByRole("button", { name: "Turn off link" }),
|
||||
).toBeInTheDocument();
|
||||
});
|
||||
|
||||
it("calls onClose when Done is clicked", async () => {
|
||||
const user = userEvent.setup();
|
||||
const onClose = vi.fn();
|
||||
render(<Share isOpen={true} onClose={onClose} {...noopHandlers} />);
|
||||
render(
|
||||
<Share
|
||||
isOpen
|
||||
onClose={onClose}
|
||||
previewSettings={previewSettings}
|
||||
/>,
|
||||
);
|
||||
await user.click(screen.getByRole("button", { name: "Done" }));
|
||||
expect(onClose).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
it("confirms Copy link with Copied! when the handler succeeds", async () => {
|
||||
const user = userEvent.setup();
|
||||
const onCopyLink = vi.fn().mockResolvedValue(true);
|
||||
render(
|
||||
<Share
|
||||
isOpen={true}
|
||||
onClose={vi.fn()}
|
||||
{...noopHandlers}
|
||||
onCopyLink={onCopyLink}
|
||||
/>,
|
||||
);
|
||||
await user.click(screen.getByRole("button", { name: "Copy link" }));
|
||||
expect(onCopyLink).toHaveBeenCalledTimes(1);
|
||||
expect(screen.getByRole("button", { name: "Copied!" })).toHaveAttribute(
|
||||
"aria-pressed",
|
||||
"true",
|
||||
);
|
||||
expect(screen.getByText("Link copied to clipboard")).toBeInTheDocument();
|
||||
});
|
||||
|
||||
it("keeps Copy link when the handler reports failure", async () => {
|
||||
const user = userEvent.setup();
|
||||
render(
|
||||
<Share
|
||||
isOpen={true}
|
||||
onClose={vi.fn()}
|
||||
{...noopHandlers}
|
||||
onCopyLink={vi.fn().mockResolvedValue(false)}
|
||||
/>,
|
||||
);
|
||||
await user.click(screen.getByRole("button", { name: "Copy link" }));
|
||||
expect(screen.getByRole("button", { name: "Copy link" })).toBeInTheDocument();
|
||||
expect(
|
||||
screen.queryByRole("button", { name: "Copied!" }),
|
||||
).not.toBeInTheDocument();
|
||||
});
|
||||
|
||||
it("calls onClose when header overflow (more) is activated, matching modal chrome parity", async () => {
|
||||
const user = userEvent.setup();
|
||||
const onClose = vi.fn();
|
||||
render(<Share isOpen={true} onClose={onClose} {...noopHandlers} />);
|
||||
await user.click(screen.getByRole("button", { name: "More share options" }));
|
||||
expect(onClose).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
});
|
||||
Reference in new issue
Block a user