Attempt to fix playwright and performance again
CI Pipeline / test (18) (pull_request) Successful in 4m40s
CI Pipeline / test (20) (pull_request) Successful in 4m43s
CI Pipeline / e2e (chromium) (pull_request) Failing after 1m59s
CI Pipeline / e2e (firefox) (pull_request) Failing after 2m2s
CI Pipeline / e2e (webkit) (pull_request) Failing after 3m23s
CI Pipeline / visual-regression (pull_request) Failing after 3m52s
CI Pipeline / seed-vr-snapshots (pull_request) Has been skipped
CI Pipeline / storybook (pull_request) Successful in 6m3s
CI Pipeline / performance (pull_request) Successful in 8m5s
CI Pipeline / lint (pull_request) Has been cancelled
CI Pipeline / build (pull_request) Has been cancelled
CI Pipeline / test (18) (pull_request) Successful in 4m40s
CI Pipeline / test (20) (pull_request) Successful in 4m43s
CI Pipeline / e2e (chromium) (pull_request) Failing after 1m59s
CI Pipeline / e2e (firefox) (pull_request) Failing after 2m2s
CI Pipeline / e2e (webkit) (pull_request) Failing after 3m23s
CI Pipeline / visual-regression (pull_request) Failing after 3m52s
CI Pipeline / seed-vr-snapshots (pull_request) Has been skipped
CI Pipeline / storybook (pull_request) Successful in 6m3s
CI Pipeline / performance (pull_request) Successful in 8m5s
CI Pipeline / lint (pull_request) Has been cancelled
CI Pipeline / build (pull_request) Has been cancelled
This commit is contained in:
+20
-47
@@ -48,25 +48,13 @@ jobs:
|
|||||||
- uses: actions/setup-node@v4
|
- uses: actions/setup-node@v4
|
||||||
with: { node-version: 20, cache: npm }
|
with: { node-version: 20, cache: npm }
|
||||||
- run: npm ci
|
- run: npm ci
|
||||||
- name: Compute Playwright version
|
|
||||||
id: pw
|
|
||||||
run: echo "version=$(node -p \"require('@playwright/test/package.json').version\")" >> "$GITHUB_OUTPUT"
|
|
||||||
|
|
||||||
- name: Cache Playwright browsers
|
- name: Cache Playwright browsers
|
||||||
id: pw-cache
|
|
||||||
uses: actions/cache@v4
|
uses: actions/cache@v4
|
||||||
with:
|
with:
|
||||||
# macOS and Linux paths are included; missing paths are ignored.
|
path: ~/.cache/ms-playwright
|
||||||
path: |
|
key: playwright-${{ runner.os }}-${{ hashFiles('package-lock.json') }}
|
||||||
~/Library/Caches/ms-playwright
|
|
||||||
~/.cache/ms-playwright
|
|
||||||
key: playwright-${{ runner.os }}-${{ steps.pw.outputs.version }}-${{ hashFiles('package-lock.json') }}
|
|
||||||
restore-keys: |
|
|
||||||
playwright-${{ runner.os }}-${{ steps.pw.outputs.version }}-
|
|
||||||
playwright-${{ runner.os }}-
|
|
||||||
|
|
||||||
- name: Install Playwright (only if cache miss)
|
- name: Install Playwright
|
||||||
if: steps.pw-cache.outputs.cache-hit != 'true'
|
|
||||||
run: npx playwright install --with-deps ${{ matrix.browser }}
|
run: npx playwright install --with-deps ${{ matrix.browser }}
|
||||||
- run: npm run build
|
- run: npm run build
|
||||||
|
|
||||||
@@ -129,25 +117,13 @@ jobs:
|
|||||||
- uses: actions/setup-node@v4
|
- uses: actions/setup-node@v4
|
||||||
with: { node-version: 20, cache: npm }
|
with: { node-version: 20, cache: npm }
|
||||||
- run: npm ci
|
- run: npm ci
|
||||||
- name: Compute Playwright version
|
|
||||||
id: pw
|
|
||||||
run: echo "version=$(node -p \"require('@playwright/test/package.json').version\")" >> "$GITHUB_OUTPUT"
|
|
||||||
|
|
||||||
- name: Cache Playwright browsers
|
- name: Cache Playwright browsers
|
||||||
id: pw-cache
|
|
||||||
uses: actions/cache@v4
|
uses: actions/cache@v4
|
||||||
with:
|
with:
|
||||||
# macOS and Linux paths are included; missing paths are ignored.
|
path: ~/.cache/ms-playwright
|
||||||
path: |
|
key: playwright-${{ runner.os }}-${{ hashFiles('package-lock.json') }}
|
||||||
~/Library/Caches/ms-playwright
|
|
||||||
~/.cache/ms-playwright
|
|
||||||
key: playwright-${{ runner.os }}-${{ steps.pw.outputs.version }}-${{ hashFiles('package-lock.json') }}
|
|
||||||
restore-keys: |
|
|
||||||
playwright-${{ runner.os }}-${{ steps.pw.outputs.version }}-
|
|
||||||
playwright-${{ runner.os }}-
|
|
||||||
|
|
||||||
- name: Install Playwright (only if cache miss)
|
- name: Install Playwright
|
||||||
if: steps.pw-cache.outputs.cache-hit != 'true'
|
|
||||||
run: npx playwright install --with-deps
|
run: npx playwright install --with-deps
|
||||||
- run: npm run build
|
- run: npm run build
|
||||||
# 1) Sanity check that the build exists
|
# 1) Sanity check that the build exists
|
||||||
@@ -312,8 +288,17 @@ jobs:
|
|||||||
# Ensure we're using arm64 Node for Lighthouse
|
# Ensure we're using arm64 Node for Lighthouse
|
||||||
echo "Node arch: $(node -p "process.arch")"
|
echo "Node arch: $(node -p "process.arch")"
|
||||||
|
|
||||||
# Get Chrome path directly in this step
|
# Get Chrome path directly in this step (same logic as installation step)
|
||||||
CHROME_PATH=$(npx @puppeteer/browsers executable-path chrome@stable --platform=mac_arm --path .cache/puppeteer)
|
INSTALL_OUT="$(npx @puppeteer/browsers install chrome@stable --platform=mac_arm --path .cache/puppeteer 2>/dev/null || true)"
|
||||||
|
BUILD_ID="$(printf '%s\n' "$INSTALL_OUT" | awk '{print $1}' | cut -d@ -f2)"
|
||||||
|
echo "Using Chrome build: $BUILD_ID"
|
||||||
|
|
||||||
|
# Try CLI first, then fallback to find
|
||||||
|
CHROME_PATH="$(npx @puppeteer/browsers executable-path chrome@"$BUILD_ID" --platform=mac_arm --path .cache/puppeteer 2>/dev/null || true)"
|
||||||
|
if [ -z "$CHROME_PATH" ]; then
|
||||||
|
CHROME_PATH="$(/usr/bin/find ".cache/puppeteer/chrome" -type f -path "*/chrome-mac-arm64/Google Chrome for Testing.app/Contents/MacOS/Google Chrome for Testing" -print -quit 2>/dev/null || true)"
|
||||||
|
fi
|
||||||
|
|
||||||
echo "Chrome path: $CHROME_PATH"
|
echo "Chrome path: $CHROME_PATH"
|
||||||
|
|
||||||
# Verify Chrome path is not empty
|
# Verify Chrome path is not empty
|
||||||
@@ -355,25 +340,13 @@ jobs:
|
|||||||
- uses: actions/setup-node@v4
|
- uses: actions/setup-node@v4
|
||||||
with: { node-version: 20, cache: npm }
|
with: { node-version: 20, cache: npm }
|
||||||
- run: npm ci
|
- run: npm ci
|
||||||
- name: Compute Playwright version
|
|
||||||
id: pw
|
|
||||||
run: echo "version=$(node -p \"require('@playwright/test/package.json').version\")" >> "$GITHUB_OUTPUT"
|
|
||||||
|
|
||||||
- name: Cache Playwright browsers
|
- name: Cache Playwright browsers
|
||||||
id: pw-cache
|
|
||||||
uses: actions/cache@v4
|
uses: actions/cache@v4
|
||||||
with:
|
with:
|
||||||
# macOS and Linux paths are included; missing paths are ignored.
|
path: ~/.cache/ms-playwright
|
||||||
path: |
|
key: playwright-${{ runner.os }}-${{ hashFiles('package-lock.json') }}
|
||||||
~/Library/Caches/ms-playwright
|
|
||||||
~/.cache/ms-playwright
|
|
||||||
key: playwright-${{ runner.os }}-${{ steps.pw.outputs.version }}-${{ hashFiles('package-lock.json') }}
|
|
||||||
restore-keys: |
|
|
||||||
playwright-${{ runner.os }}-${{ steps.pw.outputs.version }}-
|
|
||||||
playwright-${{ runner.os }}-
|
|
||||||
|
|
||||||
- name: Install Playwright (only if cache miss)
|
- name: Install Playwright
|
||||||
if: steps.pw-cache.outputs.cache-hit != 'true'
|
|
||||||
run: npx playwright install --with-deps
|
run: npx playwright install --with-deps
|
||||||
- run: npm run build
|
- run: npm run build
|
||||||
- name: Start app + wait
|
- name: Start app + wait
|
||||||
|
|||||||
Reference in New Issue
Block a user