Keep expired invitation hashes so a request for a new link still sends mail.

Clearing the hash made the expired page report success without sending, and made the invite look accepted.
This commit is contained in:
adilallo committed 2026-11-10 15:43:30 -07:00
1 parent b4d0d085d3
commit a8b23bddc2
6 files changed
+15 -48

No files matched your search

+3 -18
View File
@@ -6,7 +6,6 @@ function store(counts: {
sessions?: number;
magicLinkTokens?: number;
emailChangeTokens?: number;
unusedInviteTokens?: number;
workshopInquiries?: number;
}) {
const sessionDeleteMany = vi.fn().mockResolvedValue({
@@ -18,9 +17,7 @@ function store(counts: {
const emailChangeDeleteMany = vi.fn().mockResolvedValue({
count: counts.emailChangeTokens ?? 0,
});
const inviteUpdateMany = vi.fn().mockResolvedValue({
count: counts.unusedInviteTokens ?? 0,
});
const inviteUpdateMany = vi.fn().mockResolvedValue({ count: 0 });
const workshopDeleteMany = vi.fn().mockResolvedValue({
count: counts.workshopInquiries ?? 0,
});
@@ -41,13 +38,12 @@ function store(counts: {
}
describe("pruneExpiredRecords", () => {
it("deletes expired tokens and sessions, and clears unused invite hashes", async () => {
it("deletes expired tokens and sessions without clearing invite hashes", async () => {
const now = new Date("2026-11-10T12:00:00.000Z");
const mocks = store({
sessions: 2,
magicLinkTokens: 3,
emailChangeTokens: 1,
unusedInviteTokens: 4,
workshopInquiries: 5,
});
@@ -57,7 +53,6 @@ describe("pruneExpiredRecords", () => {
sessions: 2,
magicLinkTokens: 3,
emailChangeTokens: 1,
unusedInviteTokens: 4,
workshopInquiries: 5,
});
@@ -70,16 +65,7 @@ describe("pruneExpiredRecords", () => {
expect(mocks.emailChangeDeleteMany).toHaveBeenCalledWith({
where: { expiresAt: { lt: now } },
});
expect(mocks.inviteUpdateMany).toHaveBeenCalledWith({
where: {
inviteTokenHash: { not: null },
inviteExpiresAt: { lt: now },
},
data: {
inviteTokenHash: null,
inviteExpiresAt: null,
},
});
expect(mocks.inviteUpdateMany).not.toHaveBeenCalled();
const workshopArg = mocks.workshopDeleteMany.mock.calls[0]?.[0] as {
where: { createdAt: { lt: Date } };
@@ -96,7 +82,6 @@ describe("pruneExpiredRecords", () => {
mocks.sessionDeleteMany.mock.calls,
mocks.magicLinkDeleteMany.mock.calls,
mocks.emailChangeDeleteMany.mock.calls,
mocks.inviteUpdateMany.mock.calls,
]);
expect(payload).not.toMatch(/tokenHash|email/);
});