Final review edit modals created

tests/components/FinalReviewPage.test.tsx

@@ -1,5 +1,6 @@
-import { useLayoutEffect } from "react";
+import { useEffect, useLayoutEffect } from "react";
 import { describe, it, expect } from "vitest";
+import { fireEvent, within } from "@testing-library/react";
 import {
   renderWithProviders as render,
   screen,
@@ -8,6 +9,30 @@ import {
 import "@testing-library/jest-dom/vitest";
 import { FinalReviewScreen } from "../../app/(app)/create/screens/review/FinalReviewScreen";
 import { useCreateFlow } from "../../app/(app)/create/context/CreateFlowContext";
+import type { CreateFlowState } from "../../app/(app)/create/types";
+
+/**
+ * Mounts the screen with a Customize-style preset selection and exposes the
+ * latest `state` to the test via `onState`. Used by the edit-modal save
+ * semantics suite below to assert what the user's edits actually persist
+ * (or don't, on close).
+ */
+function FinalReviewWithStateProbe({
+  onState,
+  initial,
+}: {
+  onState: (_state: CreateFlowState) => void;
+  initial: CreateFlowState;
+}) {
+  const { state, replaceState } = useCreateFlow();
+  useLayoutEffect(() => {
+    replaceState(initial);
+  }, [replaceState, initial]);
+  useEffect(() => {
+    onState(state);
+  }, [state, onState]);
+  return <FinalReviewScreen />;
+}
 
 const FALLBACK_CARD_TITLE = "Your community";
 const FALLBACK_CARD_DESCRIPTION_SNIPPET =
@@ -143,3 +168,221 @@ describe("FinalReviewScreen — prefilled selections", () => {
     expect(screen.queryByText("Consciousness")).not.toBeInTheDocument();
   });
 });
+
+describe("FinalReviewScreen — chip detail modal", () => {
+  it("opens the read-only detail modal when a chip is clicked, matching the preset copy", async () => {
+    render(<FinalReviewWithCustomizeSelections />);
+
+    const signalChip = await screen.findByRole("button", { name: "Signal" });
+    fireEvent.click(signalChip);
+
+    // Modal subtitle is the `supportText` from communication.json for the
+    // "signal" method — proves the chip click resolved the correct preset
+    // and reused the TemplateChipDetailModal's by-label lookup.
+    await waitFor(() => {
+      expect(
+        screen.getByText(
+          /Encrypted messaging for high-security, private coordination\./i,
+        ),
+      ).toBeInTheDocument();
+    });
+    // Core-principle section heading is shared copy from the same messages
+    // file; assert it renders to confirm the modal body hydrated.
+    expect(
+      screen.getAllByText(/core principle/i).length,
+    ).toBeGreaterThanOrEqual(1);
+  });
+
+  it("opens a core-values chip with the matching preset meaning/signals", async () => {
+    function CoreValuesHarness() {
+      const { replaceState } = useCreateFlow();
+      useLayoutEffect(() => {
+        replaceState({
+          selectedCoreValueIds: ["1"],
+          coreValuesChipsSnapshot: [
+            { id: "1", label: "Accessibility", state: "selected" },
+          ],
+        });
+      }, [replaceState]);
+      return <FinalReviewScreen />;
+    }
+    render(<CoreValuesHarness />);
+
+    const chip = await screen.findByRole("button", { name: "Accessibility" });
+    fireEvent.click(chip);
+
+    await waitFor(() => {
+      expect(
+        screen.getByText(/what does this value mean to your group\?/i),
+      ).toBeInTheDocument();
+    });
+    expect(
+      screen.getByText(/signals of violation/i),
+    ).toBeInTheDocument();
+  });
+
+  it("opens the editable Save modal for a values chip (parity with method chips)", async () => {
+    // Customize / plain custom-rule path: snapshot is set, sections is not.
+    function CoreValuesHarness() {
+      const { replaceState } = useCreateFlow();
+      useLayoutEffect(() => {
+        replaceState({
+          selectedCoreValueIds: ["1"],
+          coreValuesChipsSnapshot: [
+            { id: "1", label: "Accessibility", state: "selected" },
+          ],
+        });
+      }, [replaceState]);
+      return <FinalReviewScreen />;
+    }
+    render(<CoreValuesHarness />);
+
+    fireEvent.click(
+      await screen.findByRole("button", { name: "Accessibility" }),
+    );
+    const dialog = await screen.findByRole("dialog");
+    expect(
+      within(dialog).getByRole("button", { name: "Save" }),
+    ).toBeInTheDocument();
+    expect(
+      within(dialog).queryByRole("button", { name: "Close" }),
+    ).not.toBeInTheDocument();
+  });
+
+  it("opens the editable Save modal for a values chip in the use-without-changes flow", async () => {
+    // Mirrors the post-fix payload from `handleUseTemplateWithoutChanges`:
+    // template Values section is stripped from `sections`, snapshot +
+    // selected ids are seeded so the chip carries an `overrideKey`.
+    function UseWithoutChangesHarness() {
+      const { replaceState } = useCreateFlow();
+      useLayoutEffect(() => {
+        replaceState({
+          title: "Oak Park Commons",
+          // Values section deliberately absent — apply handler scrubs it.
+          sections: [
+            {
+              categoryName: "Communication",
+              entries: [{ title: "Signal", body: "…" }],
+            },
+          ],
+          selectedCoreValueIds: ["1"],
+          coreValuesChipsSnapshot: [
+            { id: "1", label: "Accessibility", state: "selected" },
+          ],
+        });
+      }, [replaceState]);
+      return <FinalReviewScreen />;
+    }
+    render(<UseWithoutChangesHarness />);
+
+    fireEvent.click(
+      await screen.findByRole("button", { name: "Accessibility" }),
+    );
+    const dialog = await screen.findByRole("dialog");
+    expect(
+      within(dialog).getByRole("button", { name: "Save" }),
+    ).toBeInTheDocument();
+  });
+
+});
+
+/**
+ * Save semantics for {@link FinalReviewChipEditModal}. Mirrors the
+ * "edits ride along to publish" promise documented in the modal:
+ *
+ * 1. Save starts disabled (no edits yet → nothing to persist).
+ * 2. Editing any field flips Save on; clicking it writes the typed
+ *    `{group}MethodDetailsById[id]` entry into create-flow state and
+ *    closes the modal.
+ * 3. Closing without Save discards every typed change.
+ */
+describe("FinalReviewScreen — chip edit modal save semantics", () => {
+  const baseSelections: CreateFlowState = {
+    title: "Oak Park Commons",
+    selectedCommunicationMethodIds: ["signal"],
+  };
+
+  it("starts with the Save button disabled until the user edits a field", async () => {
+    let latest: CreateFlowState = {};
+    render(
+      <FinalReviewWithStateProbe
+        onState={(s) => {
+          latest = s;
+        }}
+        initial={baseSelections}
+      />,
+    );
+    void latest;
+
+    fireEvent.click(await screen.findByRole("button", { name: "Signal" }));
+    const dialog = await screen.findByRole("dialog");
+    const saveButton = within(dialog).getByRole("button", { name: "Save" });
+    expect(saveButton).toBeDisabled();
+
+    const [firstTextarea] = within(dialog).getAllByRole("textbox");
+    fireEvent.change(firstTextarea, {
+      target: { value: "Edited principle" },
+    });
+
+    await waitFor(() => {
+      expect(
+        within(dialog).getByRole("button", { name: "Save" }),
+      ).not.toBeDisabled();
+    });
+  });
+
+  it("writes edits into communicationMethodDetailsById when Save is clicked", async () => {
+    let latest: CreateFlowState = {};
+    render(
+      <FinalReviewWithStateProbe
+        onState={(s) => {
+          latest = s;
+        }}
+        initial={baseSelections}
+      />,
+    );
+
+    fireEvent.click(await screen.findByRole("button", { name: "Signal" }));
+    const dialog = await screen.findByRole("dialog");
+    const [firstTextarea] = within(dialog).getAllByRole("textbox");
+    fireEvent.change(firstTextarea, {
+      target: { value: "Edited principle" },
+    });
+    fireEvent.click(within(dialog).getByRole("button", { name: "Save" }));
+
+    await waitFor(() => {
+      expect(screen.queryByRole("dialog")).not.toBeInTheDocument();
+    });
+    await waitFor(() => {
+      expect(
+        latest.communicationMethodDetailsById?.signal?.corePrinciple,
+      ).toBe("Edited principle");
+    });
+  });
+
+  it("discards typed edits when the modal closes without Save", async () => {
+    let latest: CreateFlowState = {};
+    render(
+      <FinalReviewWithStateProbe
+        onState={(s) => {
+          latest = s;
+        }}
+        initial={baseSelections}
+      />,
+    );
+
+    fireEvent.click(await screen.findByRole("button", { name: "Signal" }));
+    const dialog = await screen.findByRole("dialog");
+    const [firstTextarea] = within(dialog).getAllByRole("textbox");
+    fireEvent.change(firstTextarea, {
+      target: { value: "Should NOT persist" },
+    });
+
+    fireEvent.keyDown(document, { key: "Escape" });
+    await waitFor(() => {
+      expect(screen.queryByRole("dialog")).not.toBeInTheDocument();
+    });
+
+    expect(latest.communicationMethodDetailsById).toBeUndefined();
+  });
+});