Start every Rule private, with a rotating link and files that follow its readers.

New Rules stay off lists until the person who holds the pen turns on a share link, or the team features one. Uploaded files are readable only by those readers, stripped of location metadata, and deleted with the Rule, draft, or account.
This commit is contained in:
adilallo committed 2026-11-09 19:54:04 -07:00
1 parent 642551064c
commit 5cbda35e32
50 files changed
+2429 -219

No files matched your search

+14
View File
@@ -11,6 +11,8 @@ import { apiRoute } from "../../../../lib/server/apiRoute";
import { putDraftBodySchema } from "../../../../lib/server/validation/createFlowSchemas";
import { readLimitedJson } from "../../../../lib/server/validation/requestBody";
import { jsonFromZodError } from "../../../../lib/server/validation/zodHttp";
import { deleteUploadsForDraft } from "../../../../lib/server/uploads/deleteUploadedFiles";
import { linkUploadsToDraft } from "../../../../lib/server/uploads/linkUploads";
export const GET = apiRoute("drafts.me.get", async () => {
if (!isDatabaseConfigured()) {
@@ -67,6 +69,11 @@ export const PUT = apiRoute("drafts.me.put", async (request: NextRequest) => {
payload: jsonPayload,
},
});
await linkUploadsToDraft({
draftId: draft.id,
payload,
userId: user.id,
});
return NextResponse.json({
draft: { payload: draft.payload, updatedAt: draft.updatedAt },
@@ -85,6 +92,13 @@ export const DELETE = apiRoute("drafts.me.delete", async () => {
// Idempotent: missing draft is a no-op so callers can fire-and-forget after
// publish / exit without worrying about prior state.
const draft = await prisma.ruleDraft.findUnique({
where: { userId: user.id },
select: { id: true },
});
if (draft) {
await deleteUploadsForDraft(draft.id);
}
await prisma.ruleDraft.deleteMany({ where: { userId: user.id } });
return NextResponse.json({ ok: true });
+22 -16
View File
@@ -8,9 +8,11 @@ import {
notFound,
unauthorized,
} from "../../../../lib/server/responses";
import { getPublicPublishedRuleById } from "../../../../lib/server/publishedRules";
import { getReadablePublishedRule } from "../../../../lib/server/publishedRules";
import { getSessionUser } from "../../../../lib/server/session";
import { apiRoute } from "../../../../lib/server/apiRoute";
import { deleteUploadsForRule } from "../../../../lib/server/uploads/deleteUploadedFiles";
import { linkUploadsToRule } from "../../../../lib/server/uploads/linkUploads";
import { publishRuleBodySchema } from "../../../../lib/server/validation/createFlowSchemas";
import { readLimitedJson } from "../../../../lib/server/validation/requestBody";
import { jsonFromZodError } from "../../../../lib/server/validation/zodHttp";
@@ -19,29 +21,27 @@ type RouteContext = { params: Promise<{ id: string }> };
export const GET = apiRoute<RouteContext>(
"rules.byId",
async (_request, context) => {
async (request, context) => {
if (!isDatabaseConfigured()) {
return dbUnavailable();
}
const { id } = await context.params;
const rule = await getPublicPublishedRuleById(id);
if (!rule) {
const user = await getSessionUser();
const resolved = await getReadablePublishedRule({
idOrSlug: id,
user,
viaShareSlug: false,
requestPath: request.nextUrl.pathname,
});
if (!resolved) {
return notFound();
}
const user = await getSessionUser();
let viewerIsOwner = false;
if (user) {
const ownerRow = await prisma.publishedRule.findUnique({
where: { id },
select: { userId: true },
});
viewerIsOwner = ownerRow?.userId === user.id;
}
return NextResponse.json({ rule, viewerIsOwner });
return NextResponse.json({
rule: resolved.rule,
viewerIsOwner: resolved.viewerIsOwner,
});
},
);
@@ -90,6 +90,11 @@ export const PATCH = apiRoute<RouteContext>(
document: document as Prisma.InputJsonValue,
},
});
await linkUploadsToRule({
ruleId: row.id,
document,
userId: user.id,
});
return NextResponse.json({ ok: true });
},
@@ -120,6 +125,7 @@ export const DELETE = apiRoute<RouteContext>(
return forbidden("You do not have permission to delete this rule");
}
await deleteUploadsForRule(row.id);
await prisma.publishedRule.delete({ where: { id: row.id } });
return NextResponse.json({ ok: true });
+86
View File
@@ -0,0 +1,86 @@
import { NextRequest, NextResponse } from "next/server";
import { apiRoute } from "../../../../../lib/server/apiRoute";
import { isDatabaseConfigured } from "../../../../../lib/server/env";
import { getPublicOrigin } from "../../../../../lib/server/publicOrigin";
import {
dbUnavailable,
errorJson,
forbidden,
notFound,
unauthorized,
} from "../../../../../lib/server/responses";
import {
getOwnedRuleShareSettings,
patchOwnedRuleShare,
} from "../../../../../lib/server/ruleShare";
import { getSessionUser } from "../../../../../lib/server/session";
import { patchRuleShareBodySchema } from "../../../../../lib/server/validation/createFlowSchemas";
import { readLimitedJson } from "../../../../../lib/server/validation/requestBody";
import { jsonFromZodError } from "../../../../../lib/server/validation/zodHttp";
type RouteContext = { params: Promise<{ id: string }> };
export const GET = apiRoute<RouteContext>(
"rules.share.get",
async (request, context) => {
if (!isDatabaseConfigured()) {
return dbUnavailable();
}
const user = await getSessionUser();
if (!user) {
return unauthorized();
}
const { id } = await context.params;
const settings = await getOwnedRuleShareSettings({
ruleId: id,
user,
origin: getPublicOrigin(request),
});
if (settings === "not_found") return notFound();
if (settings === "forbidden") {
return forbidden("You do not have permission to share this rule");
}
return NextResponse.json({ share: settings });
},
);
export const PATCH = apiRoute<RouteContext>(
"rules.share.patch",
async (request: NextRequest, context) => {
if (!isDatabaseConfigured()) {
return dbUnavailable();
}
const user = await getSessionUser();
if (!user) {
return unauthorized();
}
const { id } = await context.params;
const parsedBody = await readLimitedJson(request);
if (parsedBody.ok === false) {
return parsedBody.response;
}
const validated = patchRuleShareBodySchema.safeParse(parsedBody.value);
if (!validated.success) {
return jsonFromZodError(validated.error);
}
const result = await patchOwnedRuleShare({
ruleId: id,
user,
origin: getPublicOrigin(request),
visibility: validated.data.visibility,
communityAgreed: validated.data.communityAgreed,
});
if (result.ok === false) {
if (result.reason === "not_found") return notFound();
if (result.reason === "community_agreed") {
return errorJson(
"validation_error",
"Our community agreed to share this Rule is required.",
400,
);
}
return forbidden("You do not have permission to change this rule");
}
return NextResponse.json({ share: result.settings });
},
);
+18
View File
@@ -25,6 +25,7 @@ import { stakeholderInviteVerifyUrl } from "../../../lib/server/ruleStakeholderI
import { STAKEHOLDER_INVITE_TTL_MS } from "../../../lib/server/ruleStakeholders";
import { getSessionUser } from "../../../lib/server/session";
import { issueGuestRuleClaimCookie } from "../../../lib/server/guestRuleClaim";
import { linkUploadsToRule } from "../../../lib/server/uploads/linkUploads";
import { apiRoute } from "../../../lib/server/apiRoute";
import { getPublicOrigin } from "../../../lib/server/publicOrigin";
import {
@@ -123,6 +124,12 @@ export const POST = apiRoute(
});
}
await linkUploadsToRule({
ruleId: rule.id,
document,
userId: null,
});
return NextResponse.json({
rule: {
id: rule.id,
@@ -155,6 +162,11 @@ export const POST = apiRoute(
document: document as Prisma.InputJsonValue,
},
});
await linkUploadsToRule({
ruleId: rule.id,
document,
userId: user.id,
});
return NextResponse.json({
rule: {
@@ -241,6 +253,12 @@ export const POST = apiRoute(
);
}
await linkUploadsToRule({
ruleId: rule.id,
document,
userId: user.id,
});
return NextResponse.json({
rule: {
id: rule.id,
+68 -7
View File
@@ -1,30 +1,91 @@
import { readFile } from "node:fs/promises";
import { NextResponse } from "next/server";
import { apiRoute } from "../../../../lib/server/apiRoute";
import { prisma } from "../../../../lib/server/db";
import { isDatabaseConfigured } from "../../../../lib/server/env";
import {
dbUnavailable,
notFound,
serverMisconfigured,
} from "../../../../lib/server/responses";
import { getReadablePublishedRule } from "../../../../lib/server/publishedRules";
import { getSessionUser } from "../../../../lib/server/session";
import { isValidUploadFileId } from "../../../../lib/server/uploads/uploadConstants";
import { resolveUploadedFileById } from "../../../../lib/server/uploads/resolveUploadedFile";
import { getUploadRootFromEnv } from "../../../../lib/server/uploads/uploadRoot";
import { browserHoldsUploadGrant } from "../../../../lib/server/uploads/uploadGrantCookie";
import { RULE_VISIBILITY } from "../../../../lib/ruleVisibility";
type RouteContext = { params: Promise<{ id: string }> };
/**
* Public read for opaque upload ids (no auth). Unguessable UUID stem;
* do not use for sensitive documents without revisiting policy.
*/
function cacheControlForVisibility(
visibility: "private" | "shared_by_link" | "public_and_featured" | null,
): string {
if (visibility === RULE_VISIBILITY.public_and_featured) {
return "public, max-age=3600";
}
return "private, no-store";
}
export const GET = apiRoute<RouteContext>(
"uploads.byId",
async (_request, context) => {
async (request, context) => {
if (!getUploadRootFromEnv()) {
return serverMisconfigured(
"File uploads are not configured (UPLOAD_ROOT is unset).",
);
}
if (!isDatabaseConfigured()) {
return dbUnavailable();
}
const { id } = await context.params;
const resolved = await resolveUploadedFileById(id);
if (!isValidUploadFileId(id)) {
return notFound("Upload not found");
}
const row = await prisma.upload.findUnique({
where: { id: id.toLowerCase() },
select: {
id: true,
userId: true,
draftId: true,
ruleId: true,
rule: { select: { visibility: true } },
draft: { select: { userId: true } },
},
});
if (!row) {
return notFound("Upload not found");
}
const user = await getSessionUser();
let allowed = false;
let visibility: "private" | "shared_by_link" | "public_and_featured" | null =
row.rule?.visibility ?? null;
if (row.ruleId) {
const resolved = await getReadablePublishedRule({
idOrSlug: row.ruleId,
user,
viaShareSlug: visibility === RULE_VISIBILITY.shared_by_link,
requestPath: request.nextUrl.pathname,
});
allowed = resolved != null;
visibility = resolved?.visibility ?? visibility;
} else if (row.draftId) {
allowed = Boolean(user && row.draft?.userId === user.id);
} else if (user && row.userId === user.id) {
allowed = true;
} else if (!user) {
allowed = await browserHoldsUploadGrant(row.id);
}
if (!allowed) {
return notFound("Upload not found");
}
const resolved = await resolveUploadedFileById(row.id);
if (!resolved) {
return notFound("Upload not found");
}
@@ -34,7 +95,7 @@ export const GET = apiRoute<RouteContext>(
status: 200,
headers: {
"Content-Type": resolved.contentType,
"Cache-Control": "public, max-age=31536000, immutable",
"Cache-Control": cacheControlForVisibility(visibility),
"X-Content-Type-Options": "nosniff",
},
});
+10
View File
@@ -11,6 +11,7 @@ import { getSessionUser } from "../../../lib/server/session";
import { apiRoute } from "../../../lib/server/apiRoute";
import { rateLimitKey } from "../../../lib/server/rateLimit";
import { saveCreateFlowUpload } from "../../../lib/server/uploads/saveCreateFlowUpload";
import { issueGuestUploadGrantCookie } from "../../../lib/server/uploads/uploadGrantCookie";
import { getUploadRootFromEnv } from "../../../lib/server/uploads/uploadRoot";
import {
CREATE_FLOW_UPLOAD_MAX_BYTES,
@@ -146,6 +147,7 @@ export const POST = apiRoute("uploads.post", async (request: NextRequest) => {
const saved = await saveCreateFlowUpload({
purpose: purposeRaw,
buffer: buf,
userId: user?.id ?? null,
});
if ("error" in saved) {
@@ -171,6 +173,14 @@ export const POST = apiRoute("uploads.post", async (request: NextRequest) => {
);
}
if (!user) {
try {
await issueGuestUploadGrantCookie(saved.id);
} catch {
// Cookie is best-effort; the file is already stored.
}
}
return NextResponse.json({
url: saved.urlPath,
id: saved.id,
+4 -5
View File
@@ -11,15 +11,13 @@ import {
getSessionUser,
} from "../../../../lib/server/session";
import { apiRoute } from "../../../../lib/server/apiRoute";
import { deleteUploadsForUser } from "../../../../lib/server/uploads/deleteUploadedFiles";
/**
* Delete the signed-in user and associated data.
*
* **Policy (CR-86 / Ticket 15):** Prisma `User` deletion cascades `Session` and
* `RuleDraft`. `PublishedRule` uses `onDelete: SetNull` on `userId`, so published
* rules remain public with `userId = null` (anonymous/orphan rows) rather than
* being removed with the account. Change would require a schema migration if
* product later requires deleting all published rules with the user.
* Prisma `User` deletion cascades `Session`, `RuleDraft`, and `PublishedRule`
* (and uploads linked to those rows). Disk files are removed first.
*/
export const DELETE = apiRoute("user.me.delete", async () => {
if (!isDatabaseConfigured()) {
@@ -32,6 +30,7 @@ export const DELETE = apiRoute("user.me.delete", async () => {
}
try {
await deleteUploadsForUser(user.id);
await prisma.user.delete({ where: { id: user.id } });
} catch {
return internalError("Failed to delete account");