fix: suppress source field when it duplicates author, fix leading separator
- When source equals @username (same as the author), don't show SOURCE line - When source is empty, don't show a leading · separator before 'authored by' - Collections say 'curated by' instead of 'authored by'
This commit is contained in:
Executable → Regular
+4
-4
@@ -340,9 +340,9 @@ function renderDetail(p) {
|
|||||||
'<div class="content"><h4>' + escapeHtml(s.headline) + '</h4><p>' + escapeHtml(s.description || '') + '</p></div></div>';
|
'<div class="content"><h4>' + escapeHtml(s.headline) + '</h4><p>' + escapeHtml(s.description || '') + '</p></div></div>';
|
||||||
}).join('');
|
}).join('');
|
||||||
const forkNotice = (p.forked_from && p.forked_from !== 'null') ? '<div class="fork-notice">forked from: <a href="#protocols/' + p.forked_from + '" onclick="showDetail(\'' + p.forked_from + '\');return false">' + p.forked_from + '</a></div>' : '';
|
const forkNotice = (p.forked_from && p.forked_from !== 'null') ? '<div class="fork-notice">forked from: <a href="#protocols/' + p.forked_from + '" onclick="showDetail(\'' + p.forked_from + '\');return false">' + p.forked_from + '</a></div>' : '';
|
||||||
const sourceLine = p.source ? 'SOURCE: ' + escapeHtml(p.source) : '';
|
const sourceLine = (p.source && p.source !== '@' + (p.author || '')) ? 'SOURCE: ' + escapeHtml(p.source) : '';
|
||||||
var sourceLink = p.source_url ? ' · <a href="' + escapeHtml(p.source_url) + '" target="_blank">view_original</a>' : '';
|
var sourceLink = p.source_url ? ' · <a href="' + escapeHtml(p.source_url) + '" target="_blank">view_original</a>' : '';
|
||||||
var authorLine = p.author ? ' · authored by <a href="#user/' + p.author + '" onclick="showUser(\'' + p.author + '\');return false">@' + escapeHtml(p.author) + '</a>' : '';
|
var authorLine = p.author ? (sourceLine ? ' · ' : '') + 'authored by <a href="#user/' + p.author + '" onclick="showUser(\'' + p.author + '\');return false">@' + escapeHtml(p.author) + '</a>' : '';
|
||||||
var dateLine = p.created_at ? ' · added ' + formatDate(p.created_at) : '';
|
var dateLine = p.created_at ? ' · added ' + formatDate(p.created_at) : '';
|
||||||
|
|
||||||
return '<div class="detail-header"><div class="tag-row">' + tags + '</div>' +
|
return '<div class="detail-header"><div class="tag-row">' + tags + '</div>' +
|
||||||
@@ -742,8 +742,8 @@ async function showCollectionDetail(slug) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
var sourceLine = c.source ? 'SOURCE: ' + escapeHtml(c.source) : '';
|
var sourceLine = (c.source && c.source !== '@' + (c.author || '')) ? 'SOURCE: ' + escapeHtml(c.source) : '';
|
||||||
var authorLine = c.author ? ' · authored by <a href="#user/' + c.author + '" onclick="showUser(\'' + c.author + '\');return false">@' + escapeHtml(c.author) + '</a>' : '';
|
var authorLine = c.author ? (sourceLine ? ' · ' : '') + 'curated by <a href="#user/' + c.author + '" onclick="showUser(\'' + c.author + '\');return false">@' + escapeHtml(c.author) + '</a>' : '';
|
||||||
var dateLine = c.created_at ? ' · added ' + formatDate(c.created_at) : '';
|
var dateLine = c.created_at ? ' · added ' + formatDate(c.created_at) : '';
|
||||||
|
|
||||||
document.getElementById('collectionDetailContent').innerHTML =
|
document.getElementById('collectionDetailContent').innerHTML =
|
||||||
|
|||||||
Reference in New Issue
Block a user