From f2989df305c8b680f34005201e0945c12620e832 Mon Sep 17 00:00:00 2001 From: Adam Voss Date: Fri, 10 Feb 2017 22:28:52 +0000 Subject: [PATCH] Update .gitlab-ci.yml and README.md to specify production Jekyll configuration If a user is using GitLab Pages it is most likely the user is using GitLab pages to publish a website not just stage a website that is published elsewhere. If a user is publishing a website with Jekyll, they (and Jekyll themes/plugins) will expect that JEKYLL_ENV=production. This commit provides that specification in `.gitlab-ci.yml`. An examination of the existing repository showed this should not result in any change to the current rendering of the website. However, the specification may be important for developers as explained in preceding commit. --- .gitlab-ci.yml | 8 ++++++-- README.md | 3 +++ 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index bbdc3b3..0ae5b86 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -1,9 +1,14 @@ image: ruby:2.3 +variables: + JEKYLL_ENV: production + +before_script: + - bundle install + test: stage: test script: - - bundle - bundle exec jekyll build -d test artifacts: paths: @@ -14,7 +19,6 @@ test: pages: stage: deploy script: - - bundle - bundle exec jekyll build -d public artifacts: paths: diff --git a/README.md b/README.md index 83f58e9..657b5a4 100644 --- a/README.md +++ b/README.md @@ -56,6 +56,9 @@ defined in [`.gitlab-ci.yml`](.gitlab-ci.yml): ``` image: ruby:2.3 +variables: + JEKYLL_ENV: production + pages: script: - gem install jekyll