From da6388eef3afcc60a7e38d90f35e0656ff49a5b8 Mon Sep 17 00:00:00 2001 From: adilallo <39313955+adilallo@users.noreply.github.com> Date: Wed, 11 Nov 2026 11:39:57 -0700 Subject: [PATCH] Keep a failed Profile rules load from looking like an empty account. --- app/(app)/profile/ProfilePageClient.tsx | 6 ++++- .../profile/_components/ProfilePage.view.tsx | 8 +++++- tests/pages/profile.test.tsx | 27 +++++++++++++++++++ 3 files changed, 39 insertions(+), 2 deletions(-) diff --git a/app/(app)/profile/ProfilePageClient.tsx b/app/(app)/profile/ProfilePageClient.tsx index 2f36123..2b527c8 100644 --- a/app/(app)/profile/ProfilePageClient.tsx +++ b/app/(app)/profile/ProfilePageClient.tsx @@ -60,6 +60,7 @@ export default function ProfilePageClient() { const [sessionLoaded, setSessionLoaded] = useState(false); const [user, setUser] = useState<{ id: string; email: string } | null>(null); const [rules, setRules] = useState([]); + const [rulesLoaded, setRulesLoaded] = useState(false); const [rulesError, setRulesError] = useState(false); const [draft, setDraft] = useState< Awaited> @@ -92,6 +93,7 @@ export default function ProfilePageClient() { setSessionLoaded(true); if (!u) { setRules([]); + setRulesLoaded(false); setRulesError(false); setDraft(null); return; @@ -101,10 +103,11 @@ export default function ProfilePageClient() { fetchServerDraftForProfile(), ]); if (r === null) { - setRules([]); + setRulesLoaded(false); setRulesError(true); } else { setRules(r); + setRulesLoaded(true); setRulesError(false); } setDraft(d); @@ -435,6 +438,7 @@ export default function ProfilePageClient() { profileLgUp={isProfileLgUp} profileListSize={isProfileXlUp ? "l" : "m"} rules={rules} + rulesLoaded={rulesLoaded} rulesError={rulesError} draft={draft} showDraftCard={showDraftCard} diff --git a/app/(app)/profile/_components/ProfilePage.view.tsx b/app/(app)/profile/_components/ProfilePage.view.tsx index 08a9f7d..48d442d 100644 --- a/app/(app)/profile/_components/ProfilePage.view.tsx +++ b/app/(app)/profile/_components/ProfilePage.view.tsx @@ -46,6 +46,8 @@ export type ProfilePageViewProps = { /** `m` = {@link List} M; `l` = List L at `xl` per Figma `22143:900256`. */ profileListSize: Extract; rules: MyPublishedRule[]; + /** True only after `fetchMyPublishedRules` succeeds. Dismissing the warning does not set this. */ + rulesLoaded: boolean; rulesError: boolean; draft: ServerDraftForProfile | null; showDraftCard: boolean; @@ -171,6 +173,7 @@ export function ProfilePageView({ profileLgUp, profileListSize, rules, + rulesLoaded, rulesError, draft, showDraftCard, @@ -235,7 +238,10 @@ export function ProfilePageView({ ? t("welcomeBodyFirstRule") : undefined; const showEmptyYourRules = - ownedRules.length === 0 && !showDraftCard && !rulesError; + rulesLoaded && + ownedRules.length === 0 && + !showDraftCard && + !rulesError; const profileOptionsItems = useMemo((): ListItem[] => { return [ diff --git a/tests/pages/profile.test.tsx b/tests/pages/profile.test.tsx index 0a696ac..a24976c 100644 --- a/tests/pages/profile.test.tsx +++ b/tests/pages/profile.test.tsx @@ -27,6 +27,7 @@ function viewProps( profileLgUp: true, profileListSize: "l", rules: [], + rulesLoaded: true, rulesError: false, draft: null, showDraftCard: false, @@ -128,6 +129,32 @@ describe("ProfilePageView", () => { expect(onStartNewCustomRule).toHaveBeenCalledTimes(1); }); + test("keeps the No Rules card hidden when a failed load warning is dismissed", () => { + const { rerender } = render( + , + ); + + expect(screen.getByText(copy.rulesLoadBannerTitle)).toBeInTheDocument(); + expect( + screen.queryByRole("heading", { name: copy.emptyCardTitle }), + ).not.toBeInTheDocument(); + + rerender( + , + ); + + expect( + screen.queryByText(copy.rulesLoadBannerTitle), + ).not.toBeInTheDocument(); + expect( + screen.queryByRole("heading", { name: copy.emptyCardTitle }), + ).not.toBeInTheDocument(); + }); + test("asks for confirmation before deleting the account", async () => { const user = userEvent.setup(); const onOpenDeleteAccount = vi.fn();