From ae1a148b98e0b6ceeaef370a53b6df82bbe1b236 Mon Sep 17 00:00:00 2001 From: adilallo <39313955+adilallo@users.noreply.github.com> Date: Thu, 12 Nov 2026 17:09:51 -0700 Subject: [PATCH] Call the emailed link a login link on the login screens, and keep the nav label as Log in. --- messages/en/metadata.json | 2 +- messages/en/pages/login.json | 6 +++--- tests/components/Top.test.tsx | 12 ++++++++++++ 3 files changed, 16 insertions(+), 4 deletions(-) diff --git a/messages/en/metadata.json b/messages/en/metadata.json index 7635517..9e5ff64 100644 --- a/messages/en/metadata.json +++ b/messages/en/metadata.json @@ -51,7 +51,7 @@ }, "login": { "title": "Log in", - "description": "Enter your email and we'll send you a magic link to sign in. No password needed!" + "description": "Enter your email and we'll send you a login link. No password needed." }, "invite": { "title": "Invitation", diff --git a/messages/en/pages/login.json b/messages/en/pages/login.json index b68d268..d969a6f 100644 --- a/messages/en/pages/login.json +++ b/messages/en/pages/login.json @@ -2,11 +2,11 @@ "title": "Log in to CommunityRule", "subtitle": "Enter your email and we'll send you a login link. No password needed.", "saveProgressTitle": "Save your progress?", - "saveProgressSubtitle": "We need your email to save, and we'll send you a magic link to log in. If you don't save now you could lose your progress.", + "saveProgressSubtitle": "We need your email to save, and we'll send you a login link. If you don't save now you could lose your progress.", "keepRuleTitle": "Log in to keep this rule on your profile", - "keepRuleSubtitle": "Enter your email and we'll send a magic link. Open it on this same browser to attach the rule to your account. You can also continue without saving.", + "keepRuleSubtitle": "Enter your email and we'll send a login link. Open it on this same browser to attach the rule to your account. You can also continue without saving.", "inviteTitle": "Log in to invite your members", - "inviteSubtitle": "Only a logged-in person can invite. Enter your email and we’ll send you a magic link to log in.", + "inviteSubtitle": "Only a logged-in person can invite. Enter your email and we’ll send you a login link.", "backToYourRule": "← Back to your Rule", "continueWithoutSaving": "Continue without saving", "emailLabel": "Email address", diff --git a/tests/components/Top.test.tsx b/tests/components/Top.test.tsx index 55f393d..34b82bb 100644 --- a/tests/components/Top.test.tsx +++ b/tests/components/Top.test.tsx @@ -173,6 +173,18 @@ describe("Top header chrome", () => { ).toHaveAttribute("href", "/workshops"); }); + it("labels the signed-out control Log in, not Sign in", () => { + renderWithProviders(); + const logInControls = screen.getAllByRole("menuitem", { + name: /log in to your account/i, + }); + expect(logInControls.length).toBeGreaterThan(0); + logInControls.forEach((control) => { + expect(control).toHaveTextContent("Log in"); + }); + expect(screen.queryByText("Sign in")).not.toBeInTheDocument(); + }); + it("shows Profile instead of Log in when signed in", () => { renderWithProviders(); expect(