From 89f3e5684deef9340b716a7c37629ebaaf5b4ea2 Mon Sep 17 00:00:00 2001
From: adilallo <39313955+adilallo@users.noreply.github.com>
Date: Mon, 28 Sep 2026 15:08:12 -0600
Subject: [PATCH] Place account deletion in its own danger row so it stays
 separate from routine options.

Co-authored-by: Cursor <cursoragent@cursor.com>
---
 .../profile/_components/ProfilePage.view.tsx  | 42 ++++++++-----------
 .../layout/ListEntry/ListEntry.view.tsx       | 11 +----
 tests/pages/profile.test.tsx                  | 36 ++++++++--------
 3 files changed, 38 insertions(+), 51 deletions(-)

diff --git a/app/(app)/profile/_components/ProfilePage.view.tsx b/app/(app)/profile/_components/ProfilePage.view.tsx
index 18cf267..7f1db4e 100644
--- a/app/(app)/profile/_components/ProfilePage.view.tsx
+++ b/app/(app)/profile/_components/ProfilePage.view.tsx
@@ -6,6 +6,7 @@ import Rule from "../../../components/cards/Rule";
 import TextInput from "../../../components/controls/TextInput";
 import List from "../../../components/layout/List";
 import type { ListItem, ListSize } from "../../../components/layout/List";
+import ListEntry from "../../../components/layout/ListEntry";
 import Icon from "../../../components/asset/icon";
 import Dialog from "../../../components/modals/Dialog";
 import Alert from "../../../components/modals/Alert";
@@ -397,33 +398,24 @@ export function ProfilePageView({
                   leadingIcon="edit"
                 />
               </nav>
+              <section
+                aria-label={t("deleteAccount")}
+                className="w-full overflow-hidden rounded-[12px] border border-[var(--color-border-default-negative-primary)] bg-[var(--color-surface-default-negative-secondary)]"
+              >
+                <ListEntry
+                  title={t("deleteAccount")}
+                  description=""
+                  showDescription={false}
+                  onClick={onOpenDeleteAccount}
+                  size={profileListSize}
+                  leadingIcon="edit"
+                  variant="danger"
+                  topDivider={false}
+                  bottomDivider={false}
+                />
+              </section>
             </section>
           </div>
-
-          <section
-            className="flex w-full flex-col items-start gap-3 rounded-[12px] border border-[var(--color-border-default-negative-primary)] bg-[var(--color-surface-default-negative-secondary)] px-4 py-4 lg:px-6 lg:py-6"
-            aria-labelledby="profile-delete-heading"
-          >
-            <h2
-              id="profile-delete-heading"
-              className="text-small-label text-[var(--color-content-default-negative-primary)]"
-            >
-              {t("deleteAccount")}
-            </h2>
-            <p className="max-w-[640px] text-small-paragraph text-[var(--color-content-default-secondary)]">
-              {t("deleteAccountIntro")}
-            </p>
-            <Button
-              type="button"
-              size="small"
-              buttonType="danger"
-              palette="default"
-              className="self-start"
-              onClick={onOpenDeleteAccount}
-            >
-              {t("deleteAccountConfirm")}
-            </Button>
-          </section>
         </div>
       </div>
 
diff --git a/app/components/layout/ListEntry/ListEntry.view.tsx b/app/components/layout/ListEntry/ListEntry.view.tsx
index 3380d3d..b09534c 100644
--- a/app/components/layout/ListEntry/ListEntry.view.tsx
+++ b/app/components/layout/ListEntry/ListEntry.view.tsx
@@ -51,15 +51,8 @@ const ListEntryRow = memo(function ListEntryRow({
       ? `${layout.title} !text-[var(--color-content-default-negative-primary)]`
       : layout.title;
 
-  const leadingToneClass =
-    variant === "danger"
-      ? "text-[var(--color-content-default-negative-primary)]"
-      : "text-[var(--color-content-default-primary)]";
-
-  const chevronToneClass =
-    variant === "danger"
-      ? "text-[var(--color-content-default-negative-primary)]"
-      : "text-[var(--color-content-default-primary)]";
+  const leadingToneClass = "text-[var(--color-content-default-primary)]";
+  const chevronToneClass = "text-[var(--color-content-default-primary)]";
 
   const leadingSlot = (
     <div className={`${leadingBoxClass} ${leadingToneClass}`}>
diff --git a/tests/pages/profile.test.tsx b/tests/pages/profile.test.tsx
index 486e906..cdfb35e 100644
--- a/tests/pages/profile.test.tsx
+++ b/tests/pages/profile.test.tsx
@@ -69,34 +69,36 @@ function viewProps(
 }
 
 describe("ProfilePageView", () => {
-  test("keeps account deletion out of the routine options list", () => {
+  test("puts delete account in its own danger area", () => {
     render(<ProfilePageView {...viewProps()} />);
 
     const options = screen.getByRole("navigation", {
       name: copy.yourOptionsHeading,
     });
-    const createRule = within(options).getByRole("button", {
-      name: copy.optionCreateCustom,
-    });
-    expect(createRule.closest("ul")).not.toBeNull();
     expect(
-      within(options).queryByRole("button", { name: copy.deleteAccountConfirm }),
-    ).not.toBeInTheDocument();
+      within(options).getByRole("button", { name: copy.optionCreateCustom }),
+    ).toBeInTheDocument();
     expect(
-      within(options).queryByRole("heading", { name: copy.deleteAccount }),
+      within(options).queryByRole("button", { name: copy.deleteAccount }),
     ).not.toBeInTheDocument();
+    expect(screen.queryByText(copy.deleteAccountIntro)).not.toBeInTheDocument();
 
     const danger = screen.getByRole("region", { name: copy.deleteAccount });
-    expect(danger).toHaveTextContent(copy.deleteAccountIntro);
-    const deleteAccount = within(danger).getByRole("button", {
-      name: copy.deleteAccountConfirm,
-    });
-    expect(deleteAccount.closest("ul")).toBeNull();
-    expect(deleteAccount.className).toContain(
+    expect(danger.className).toContain(
       "border-[var(--color-border-default-negative-primary)]",
     );
-    expect(deleteAccount.className).not.toContain(
-      "bg-[var(--color-surface-inverse-primary)]",
+    const deleteAccount = within(danger).getByRole("button", {
+      name: copy.deleteAccount,
+    });
+    const deleteTitle = within(deleteAccount).getByText(copy.deleteAccount);
+    expect(deleteTitle.className).toContain(
+      "!text-[var(--color-content-default-negative-primary)]",
+    );
+    expect(deleteAccount.firstElementChild?.className).not.toContain(
+      "negative-primary",
+    );
+    expect(deleteAccount.lastElementChild?.className).not.toContain(
+      "negative-primary",
     );
   });
 
@@ -109,7 +111,7 @@ describe("ProfilePageView", () => {
     );
 
     await user.click(
-      screen.getByRole("button", { name: copy.deleteAccountConfirm }),
+      screen.getByRole("button", { name: copy.deleteAccount }),
     );
     expect(onOpenDeleteAccount).toHaveBeenCalledTimes(1);