From 64a542f456c2348c3cc688e1af67d0d7e5b21553 Mon Sep 17 00:00:00 2001 From: adilallo <39313955+adilallo@users.noreply.github.com> Date: Thu, 5 Nov 2026 21:28:00 -0700 Subject: [PATCH] Open each core value as a card of meaning and signals steps, so groups write their own words from an empty field with Generate draft, skip values without blocking the flow, and Customize without keeping helper text as the description. --- app/(app)/create/CreateFlowLayoutClient.tsx | 81 ++++-- .../CustomMethodCardWizard.container.tsx | 1 - .../components/FinalReviewChipEditModal.tsx | 102 ++++--- .../create/components/ModalTextAreaField.tsx | 46 ++- app/(app)/create/components/ValueDialog.tsx | 181 ++++++++++++ .../create/components/ValueDialogStepCard.tsx | 100 +++++++ .../methodEditFields/CoreValueEditFields.tsx | 74 ----- .../components/methodEditFields/index.ts | 3 - .../screens/select/CoreValuesSelectScreen.tsx | 146 ++++------ .../controls/MultiSelect/MultiSelect.view.tsx | 2 +- .../modals/Create/Create.container.tsx | 6 + app/components/modals/Create/Create.types.ts | 6 + app/components/modals/Create/Create.view.tsx | 6 + .../ModalFooter/ModalFooter.container.tsx | 2 + .../modals/ModalFooter/ModalFooter.types.ts | 9 + .../modals/ModalFooter/ModalFooter.view.tsx | 38 ++- messages/en/common.json | 1 + messages/en/create/customRule/coreValues.json | 26 +- .../CoreValuesSelectScreen.test.tsx | 266 ++++++++++++------ tests/components/Create.test.tsx | 20 ++ tests/components/FinalReviewPage.test.tsx | 49 +++- tests/components/ModalFooter.test.tsx | 27 +- tests/components/ModalTextAreaField.test.tsx | 23 ++ tests/components/MultiSelect.test.tsx | 12 + tests/unit/createFooterMessages.test.ts | 4 + 25 files changed, 877 insertions(+), 354 deletions(-) create mode 100644 app/(app)/create/components/ValueDialog.tsx create mode 100644 app/(app)/create/components/ValueDialogStepCard.tsx delete mode 100644 app/(app)/create/components/methodEditFields/CoreValueEditFields.tsx diff --git a/app/(app)/create/CreateFlowLayoutClient.tsx b/app/(app)/create/CreateFlowLayoutClient.tsx index 6a968a6..33d3f3c 100644 --- a/app/(app)/create/CreateFlowLayoutClient.tsx +++ b/app/(app)/create/CreateFlowLayoutClient.tsx @@ -1065,35 +1065,60 @@ function CreateFlowLayoutContent({ ) : showCustomRuleFooterConfirm && customRuleConfirmFooter ? ( - + ) : null} + + className={CREATE_FLOW_FOOTER_BUTTON_CLASS} + onClick={() => { + const cf = customRuleConfirmFooter; + const facet = methodCardFacetSectionForConfirmStep(cf.step); + if (facet != null && cf.selectionIds(state).length > 0) { + setMethodSectionsPinCommitted(facet, true); + } + if (reviewReturnTarget) { + router.push( + createFlowStepPathAfterStrippingReviewReturn( + reviewReturnTarget, + searchParams, + ), + ); + return; + } + goToNextStep(); + }} + > + {footer[customRuleConfirmFooter.footerMessageKey]} + + ) : isConfirmStakeholdersManagePublished ? (