From 59f76c5b7d6f2adf54c0e10194b0b31e9a393288 Mon Sep 17 00:00:00 2001 From: adilallo <39313955+adilallo@users.noreply.github.com> Date: Thu, 5 Nov 2026 22:47:46 -0700 Subject: [PATCH] Keep catalog copy on a selected method card, and only offer See all when the deck is longer than the compact seven. --- .../card/CommunicationMethodsScreen.tsx | 2 +- .../screens/card/ConflictManagementScreen.tsx | 2 +- .../screens/card/MembershipMethodsScreen.tsx | 2 +- .../right-rail/DecisionApproachesScreen.tsx | 2 +- .../cards/CardStack/CardStack.view.tsx | 4 +- tests/unit/CardStack.test.jsx | 49 +++++++++++++++++++ 6 files changed, 55 insertions(+), 6 deletions(-) diff --git a/app/(app)/create/screens/card/CommunicationMethodsScreen.tsx b/app/(app)/create/screens/card/CommunicationMethodsScreen.tsx index c4c915f..64aa4d5 100644 --- a/app/(app)/create/screens/card/CommunicationMethodsScreen.tsx +++ b/app/(app)/create/screens/card/CommunicationMethodsScreen.tsx @@ -715,7 +715,7 @@ export function CommunicationMethodsScreen() { markCreateFlowInteraction(); setExpanded((prev) => !prev); }} - hasMore={true} + hasMore={sampleCards.length > compactLimit} toggleLabel={comm.page.seeAllLink} compactRecommendedLimit={compactLimit} compactCardIds={compactCardIds} diff --git a/app/(app)/create/screens/card/ConflictManagementScreen.tsx b/app/(app)/create/screens/card/ConflictManagementScreen.tsx index deb508a..50b70f3 100644 --- a/app/(app)/create/screens/card/ConflictManagementScreen.tsx +++ b/app/(app)/create/screens/card/ConflictManagementScreen.tsx @@ -716,7 +716,7 @@ export function ConflictManagementScreen() { markCreateFlowInteraction(); setExpanded((prev) => !prev); }} - hasMore={true} + hasMore={sampleCards.length > compactLimit} toggleLabel={cm.page.seeAllLink} compactRecommendedLimit={compactLimit} compactCardIds={compactCardIds} diff --git a/app/(app)/create/screens/card/MembershipMethodsScreen.tsx b/app/(app)/create/screens/card/MembershipMethodsScreen.tsx index 0327a89..d62bd31 100644 --- a/app/(app)/create/screens/card/MembershipMethodsScreen.tsx +++ b/app/(app)/create/screens/card/MembershipMethodsScreen.tsx @@ -708,7 +708,7 @@ export function MembershipMethodsScreen() { markCreateFlowInteraction(); setExpanded((prev) => !prev); }} - hasMore={true} + hasMore={sampleCards.length > compactLimit} toggleLabel={mem.page.seeAllLink} compactRecommendedLimit={compactLimit} compactCardIds={compactCardIds} diff --git a/app/(app)/create/screens/right-rail/DecisionApproachesScreen.tsx b/app/(app)/create/screens/right-rail/DecisionApproachesScreen.tsx index fcdf98b..582dd56 100644 --- a/app/(app)/create/screens/right-rail/DecisionApproachesScreen.tsx +++ b/app/(app)/create/screens/right-rail/DecisionApproachesScreen.tsx @@ -780,7 +780,7 @@ export function DecisionApproachesScreen() { onCardSelect={handleCardSelect} expanded={expanded} onToggleExpand={handleToggleExpand} - hasMore={true} + hasMore={sampleCards.length > compactLimit} toggleLabel={da.cardStack.toggleSeeAll} showLessLabel={da.cardStack.toggleShowLess} title="" diff --git a/app/components/cards/CardStack/CardStack.view.tsx b/app/components/cards/CardStack/CardStack.view.tsx index b4881c9..9478149 100644 --- a/app/components/cards/CardStack/CardStack.view.tsx +++ b/app/components/cards/CardStack/CardStack.view.tsx @@ -84,12 +84,12 @@ function StackCard({ alternativePrefix: string; }) { const supportText = - !expanded && item.compactSupportText + !expanded && !selected && item.compactSupportText ? item.compactSupportText : item.supportText; const recommended = Boolean(expanded && item.recommended); const alternative = - !expanded && item.alternative && onAlternativeSelect ? ( + !expanded && !selected && item.alternative && onAlternativeSelect ? (
{alternativePrefix}{" "}